archive mirror
 help / color / mirror / Atom feed
From: Andrei Vagin <>
To: "Eric W. Biederman" <>
Cc:, Kees Cook <>,, Andrei Vagin <>
Subject: [PATCH] exec/binfmt_script: trip zero bytes from the buffer
Date: Tue, 15 Jun 2021 09:23:46 -0700	[thread overview]
Message-ID: <> (raw)

Without this fix, if we try to run a script that contains only the
interpreter line, the interpreter is executed with one extra empty

The code is written so that i_end has to be set to the end of valuable
data in the buffer.

Fixes: ccbb18b67323 ("exec/binfmt_script: Don't modify bprm->buf and then return -ENOEXEC")
Cc: "Eric W. Biederman" <>
Signed-off-by: Andrei Vagin <>
 fs/binfmt_script.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/binfmt_script.c b/fs/binfmt_script.c
index 1b6625e95958..e242680f96e1 100644
--- a/fs/binfmt_script.c
+++ b/fs/binfmt_script.c
@@ -68,6 +68,9 @@ static int load_script(struct linux_binprm *bprm)
 		if (!next_terminator(i_end, buf_end))
 			return -ENOEXEC;
 		i_end = buf_end;
+		/* Trim zero bytes from i_end */
+		while (i_end[-1] == 0)
+			i_end--;
 	/* Trim any trailing spaces/tabs from i_end */
 	while (spacetab(i_end[-1]))

             reply	other threads:[~2021-06-15 16:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15 16:23 Andrei Vagin [this message]
2021-06-15 19:33 ` [PATCH] exec/binfmt_script: trip zero bytes from the buffer Eric W. Biederman
2021-06-15 22:35   ` Andrei Vagin
2021-06-21 19:27     ` Eric W. Biederman
2021-06-25  8:30       ` Andrei Vagin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).