From: Jan Kara <jack@suse.cz>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>,
Matthew Bobrowski <mbobrowski@mbobrowski.org>,
linux-fsdevel@vger.kernel.org,
Oliver Sang <oliver.sang@intel.com>,
Mel Gorman <mgorman@techsingularity.net>
Subject: Re: [PATCH 0/4] Performance optimization for no fsnotify marks
Date: Tue, 10 Aug 2021 12:49:24 +0200 [thread overview]
Message-ID: <20210810104924.GD18722@quack2.suse.cz> (raw)
In-Reply-To: <20210803180344.2398374-1-amir73il@gmail.com>
Hi Amir!
On Tue 03-08-21 21:03:40, Amir Goldstein wrote:
> This idea was suggested on year ago [1], but I never got to test
> its performance benefits.
>
> Following the performance improvement report from kernel robot [2],
> please consider these changes.
>
> I have other optimization patches for no ignored mask etc, but the
> "no marks" case is the most low hanging improvement.
Thanks for the improvement! The series looks good except for that one
comment I had. If you respin the series with that addressed, I can take it
to my tree.
Honza
>
> Thanks,
> Amir.
>
> [1] https://lore.kernel.org/linux-fsdevel/CAOQ4uxgYpufPyhivOQyEhUQ0g+atKLwAAuefkSwaWXYAyMgw5Q@mail.gmail.com/
> [2] https://lore.kernel.org/linux-fsdevel/CAOQ4uxisyDjVpWX1M6O4ugxBbcX+LWWf4NQJ+LQY1-3-9tN+BA@mail.gmail.com/
>
> Amir Goldstein (4):
> fsnotify: replace igrab() with ihold() on attach connector
> fsnotify: count s_fsnotify_inode_refs for attached connectors
> fsnotify: count all objects with attached connectors
> fsnotify: optimize the case of no marks of any type
>
> fs/notify/fsnotify.c | 6 ++--
> fs/notify/mark.c | 73 +++++++++++++++++++++++++++++++++-------
> include/linux/fs.h | 4 +--
> include/linux/fsnotify.h | 9 +++++
> 4 files changed, 75 insertions(+), 17 deletions(-)
>
> --
> 2.25.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2021-08-10 10:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 18:03 [PATCH 0/4] Performance optimization for no fsnotify marks Amir Goldstein
2021-08-03 18:03 ` [PATCH 1/4] fsnotify: replace igrab() with ihold() on attach connector Amir Goldstein
2021-08-10 5:39 ` Matthew Bobrowski
2021-08-03 18:03 ` [PATCH 2/4] fsnotify: count s_fsnotify_inode_refs for attached connectors Amir Goldstein
2021-08-10 6:03 ` Matthew Bobrowski
2021-08-03 18:03 ` [PATCH 3/4] fsnotify: count all objects with " Amir Goldstein
2021-08-10 6:31 ` Matthew Bobrowski
2021-08-10 14:12 ` Amir Goldstein
2021-08-10 10:47 ` Jan Kara
2021-08-10 14:22 ` Amir Goldstein
2021-08-03 18:03 ` [PATCH 4/4] fsnotify: optimize the case of no marks of any type Amir Goldstein
2021-08-08 14:34 ` [fsnotify] e902b4cafb: unixbench.score 6.1% improvement kernel test robot
2021-08-10 6:43 ` [PATCH 4/4] fsnotify: optimize the case of no marks of any type Matthew Bobrowski
2021-08-10 10:49 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210810104924.GD18722@quack2.suse.cz \
--to=jack@suse.cz \
--cc=amir73il@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mbobrowski@mbobrowski.org \
--cc=mgorman@techsingularity.net \
--cc=oliver.sang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).