From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64DB2C433F5 for ; Thu, 23 Sep 2021 16:55:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4EB8161241 for ; Thu, 23 Sep 2021 16:55:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242331AbhIWQ4a (ORCPT ); Thu, 23 Sep 2021 12:56:30 -0400 Received: from kanga.kvack.org ([205.233.56.17]:45554 "EHLO kanga.kvack.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240732AbhIWQ4U (ORCPT ); Thu, 23 Sep 2021 12:56:20 -0400 X-Greylist: delayed 1025 seconds by postgrey-1.27 at vger.kernel.org; Thu, 23 Sep 2021 12:56:20 EDT Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C79E900002; Thu, 23 Sep 2021 12:37:43 -0400 (EDT) Date: Thu, 23 Sep 2021 12:37:43 -0400 From: Benjamin LaHaise To: Hamza Mahfooz Cc: linux-kernel@vger.kernel.org, kernel test robot , Alexander Viro , linux-fsdevel@vger.kernel.org, linux-aio@kvack.org Subject: Re: [PATCH v2] aio: convert active_reqs into a hashtable Message-ID: <20210923163743.GZ24576@kvack.org> References: <20210919144146.19531-1-someguy@effective-light.com> <20210919145645.GE16005@kvack.org> <7H1WZQ.H8D3XK8HUSNQ3@effective-light.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7H1WZQ.H8D3XK8HUSNQ3@effective-light.com> User-Agent: Mutt/1.4.2.2i Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Sep 23, 2021 at 09:00:43AM -0400, Hamza Mahfooz wrote: > Would that not mean that, we would have to keep track of the indices of > the > array that are not being held by an `aio_kiocb`? Correct. This is a better solution than the hash table and would mean that the requests list could likely be replaced by the table. -ben -- "Thought is the essence of where you are now."