From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73324C433FE for ; Thu, 6 Oct 2022 23:16:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232170AbiJFXQy (ORCPT ); Thu, 6 Oct 2022 19:16:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232345AbiJFXQu (ORCPT ); Thu, 6 Oct 2022 19:16:50 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69C4DCD5DC for ; Thu, 6 Oct 2022 16:16:49 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id f23so3047288plr.6 for ; Thu, 06 Oct 2022 16:16:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=JGLxKCv1HjPO+SVC7x6JAIJWQMGRk3XmZwZRy/JbCo0=; b=ndN9TehJV2QHvErqjrgZlY49UhMoTa/Oo9BqjYn7hVxxhJqo7zp1LFyQJVU1a+ASyy BI/aRMBEvQLD+bZ3jwtvI8NnMpnjA3bfyoYo8F+yiUfEnDnqFC5cYvTt6A8rBqhX5ZD+ 8u5Cqb6pfntMrXvEvNz+UGx+ACxsNr294hJVQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=JGLxKCv1HjPO+SVC7x6JAIJWQMGRk3XmZwZRy/JbCo0=; b=TqaGeXahxqo9gZ/e1BL4OKfqECxgfilUwAeBi98yiPw7+eSnUl6cFR57+UuIVt3p2l P0Mq6ODjqySuXtNpe+HrOJjeAOF8TedgcZ3HIBDR7GyKIhk3mdj7N6u0tvSKLL14vSmh nIt+ox7ljqe3WoVLs6aukzfO022K/wb+36iZfsSoInjaJOgy8BMlCpEEGC5e/n/TGpkJ 30L/Gjjh0ZP/bnnqj4CyWp08GjwUiJCMfL3dMvLuYOgg7Q6yHp5anjPaneov6ldUzPqu hg7tSMIlQPSQ2Wm9qrvl1dQVh4n4HeViBnf7TpeTU6FUJC9sZ/S6nzfHhNmkKGCtZHVE 4V4A== X-Gm-Message-State: ACrzQf12ztIskCTz4A240kxXNYftgUSPw7tIsmrfiuDHRbENTJ9C6V2Y tFf40IY/kXPXwxWxssRJtdHP0A== X-Google-Smtp-Source: AMsMyM4+RmM9c/OEDHEg1vJGR8qkh8RLKffK7BAjP89CeyWo989iUja+7jRInSWma3jAkyvmMBaskg== X-Received: by 2002:a17:902:b705:b0:17a:dd:4c3e with SMTP id d5-20020a170902b70500b0017a00dd4c3emr1785011pls.14.1665098208971; Thu, 06 Oct 2022 16:16:48 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id i15-20020a17090332cf00b0017f6c9622b9sm148894plr.183.2022.10.06.16.16.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Oct 2022 16:16:48 -0700 (PDT) Date: Thu, 6 Oct 2022 16:16:47 -0700 From: Kees Cook To: "Guilherme G. Piccoli" Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, anton@enomsg.org, ccross@android.com, tony.luck@intel.com, linux-efi@vger.kernel.org, Ard Biesheuvel Subject: Re: [PATCH 7/8] efi: pstore: Follow convention for the efi-pstore backend name Message-ID: <202210061616.40497D6C@keescook> References: <20221006224212.569555-1-gpiccoli@igalia.com> <20221006224212.569555-8-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221006224212.569555-8-gpiccoli@igalia.com> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Oct 06, 2022 at 07:42:11PM -0300, Guilherme G. Piccoli wrote: > For some reason, the efi-pstore backend name (exposed through the > pstore infrastructure) is hardcoded as "efi", whereas all the other > backends follow a kind of convention in using the module name. > > Let's do it here as well, to make user's life easier (they might > use this info for unloading the module backend, for example). > > Cc: Ard Biesheuvel > Signed-off-by: Guilherme G. Piccoli Looks fine to me. Ard, if you don't object, I can carry this in the pstore tree. -- Kees Cook