From: Nitesh Shetty <nj.shetty@samsung.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: Anuj Gupta <anuj20.g@samsung.com>, Jens Axboe <axboe@kernel.dk>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
dm-devel@redhat.com, Keith Busch <kbusch@kernel.org>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
James Smart <james.smart@broadcom.com>,
Chaitanya Kulkarni <kch@nvidia.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
bvanassche@acm.org, hare@suse.de, ming.lei@redhat.com,
joshi.k@samsung.com, nitheshshetty@gmail.com,
gost.dev@samsung.com, Vincent Fu <vincent.fu@samsung.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v8 9/9] null_blk: add support for copy offload
Date: Wed, 29 Mar 2023 17:52:48 +0530 [thread overview]
Message-ID: <20230329122248.GD11932@green5> (raw)
In-Reply-To: <71d9f461-a708-341f-d012-d142086c026e@opensource.wdc.com>
[-- Attachment #1: Type: text/plain, Size: 5829 bytes --]
On Wed, Mar 29, 2023 at 06:04:49PM +0900, Damien Le Moal wrote:
> On 3/27/23 17:40, Anuj Gupta wrote:
> > From: Nitesh Shetty <nj.shetty@samsung.com>
> >
> > Implementaion is based on existing read and write infrastructure.
> >
> > Suggested-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> > Signed-off-by: Anuj Gupta <anuj20.g@samsung.com>
> > Signed-off-by: Nitesh Shetty <nj.shetty@samsung.com>
> > Signed-off-by: Vincent Fu <vincent.fu@samsung.com>
> > ---
> > drivers/block/null_blk/main.c | 94 +++++++++++++++++++++++++++++++
> > drivers/block/null_blk/null_blk.h | 7 +++
> > 2 files changed, 101 insertions(+)
> >
> > diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
> > index 9e6b032c8ecc..84c5fbcd67a5 100644
> > --- a/drivers/block/null_blk/main.c
> > +++ b/drivers/block/null_blk/main.c
> > @@ -1257,6 +1257,81 @@ static int null_transfer(struct nullb *nullb, struct page *page,
> > return err;
> > }
> >
> > +static inline int nullb_setup_copy_read(struct nullb *nullb,
> > + struct bio *bio)
> > +{
> > + struct nullb_copy_token *token = bvec_kmap_local(&bio->bi_io_vec[0]);
> > +
> > + memcpy(token->subsys, "nullb", 5);
> > + token->sector_in = bio->bi_iter.bi_sector;
> > + token->nullb = nullb;
> > + token->sectors = bio->bi_iter.bi_size >> SECTOR_SHIFT;
> > +
> > + return 0;
> > +}
> > +
> > +static inline int nullb_setup_copy_write(struct nullb *nullb,
> > + struct bio *bio, bool is_fua)
> > +{
> > + struct nullb_copy_token *token = bvec_kmap_local(&bio->bi_io_vec[0]);
> > + sector_t sector_in, sector_out;
> > + void *in, *out;
> > + size_t rem, temp;
> > + unsigned long offset_in, offset_out;
> > + struct nullb_page *t_page_in, *t_page_out;
> > + int ret = -EIO;
> > +
> > + if (unlikely(memcmp(token->subsys, "nullb", 5)))
> > + return -EOPNOTSUPP;
> > + if (unlikely(token->nullb != nullb))
> > + return -EOPNOTSUPP;
> > + if (WARN_ON(token->sectors != bio->bi_iter.bi_size >> SECTOR_SHIFT))
> > + return -EOPNOTSUPP;
>
> EOPNOTSUPP is strange. These are EINVAL, no ?.
>
acked, will update in next revision.
> > +
> > + sector_in = token->sector_in;
> > + sector_out = bio->bi_iter.bi_sector;
> > + rem = token->sectors << SECTOR_SHIFT;
> > +
> > + spin_lock_irq(&nullb->lock);
> > + while (rem > 0) {
> > + temp = min_t(size_t, nullb->dev->blocksize, rem);
> > + offset_in = (sector_in & SECTOR_MASK) << SECTOR_SHIFT;
> > + offset_out = (sector_out & SECTOR_MASK) << SECTOR_SHIFT;
> > +
> > + if (null_cache_active(nullb) && !is_fua)
> > + null_make_cache_space(nullb, PAGE_SIZE);
> > +
> > + t_page_in = null_lookup_page(nullb, sector_in, false,
> > + !null_cache_active(nullb));
> > + if (!t_page_in)
> > + goto err;
> > + t_page_out = null_insert_page(nullb, sector_out,
> > + !null_cache_active(nullb) || is_fua);
> > + if (!t_page_out)
> > + goto err;
> > +
> > + in = kmap_local_page(t_page_in->page);
> > + out = kmap_local_page(t_page_out->page);
> > +
> > + memcpy(out + offset_out, in + offset_in, temp);
> > + kunmap_local(out);
> > + kunmap_local(in);
> > + __set_bit(sector_out & SECTOR_MASK, t_page_out->bitmap);
> > +
> > + if (is_fua)
> > + null_free_sector(nullb, sector_out, true);
> > +
> > + rem -= temp;
> > + sector_in += temp >> SECTOR_SHIFT;
> > + sector_out += temp >> SECTOR_SHIFT;
> > + }
> > +
> > + ret = 0;
> > +err:
> > + spin_unlock_irq(&nullb->lock);
> > + return ret;
> > +}
> > +
> > static int null_handle_rq(struct nullb_cmd *cmd)
> > {
> > struct request *rq = cmd->rq;
> > @@ -1267,6 +1342,14 @@ static int null_handle_rq(struct nullb_cmd *cmd)
> > struct req_iterator iter;
> > struct bio_vec bvec;
> >
> > + if (rq->cmd_flags & REQ_COPY) {
> > + if (op_is_write(req_op(rq)))
> > + return nullb_setup_copy_write(nullb, rq->bio,
> > + rq->cmd_flags & REQ_FUA);
> > + else
>
> No need for this else.
>
acked
> > + return nullb_setup_copy_read(nullb, rq->bio);
> > + }
> > +
> > spin_lock_irq(&nullb->lock);
> > rq_for_each_segment(bvec, rq, iter) {
> > len = bvec.bv_len;
> > @@ -1294,6 +1377,14 @@ static int null_handle_bio(struct nullb_cmd *cmd)
> > struct bio_vec bvec;
> > struct bvec_iter iter;
> >
> > + if (bio->bi_opf & REQ_COPY) {
> > + if (op_is_write(bio_op(bio)))
> > + return nullb_setup_copy_write(nullb, bio,
> > + bio->bi_opf & REQ_FUA);
> > + else
>
> No need for this else.
>
acked
> > + return nullb_setup_copy_read(nullb, bio);
> > + }
> > +
> > spin_lock_irq(&nullb->lock);
> > bio_for_each_segment(bvec, bio, iter) {
> > len = bvec.bv_len;
> > @@ -2146,6 +2237,9 @@ static int null_add_dev(struct nullb_device *dev)
> > list_add_tail(&nullb->list, &nullb_list);
> > mutex_unlock(&lock);
> >
> > + blk_queue_max_copy_sectors_hw(nullb->disk->queue, 1024);
> > + blk_queue_flag_set(QUEUE_FLAG_COPY, nullb->disk->queue);
>
> This should NOT be unconditionally enabled with a magic value of 1K sectors. The
> max copy sectors needs to be set with a configfs attribute so that we can
> enable/disable the copy offload support, to be able to exercise both block layer
> emulation and native device support.
>
acked
> > +
> > pr_info("disk %s created\n", nullb->disk_name);
> >
> > return 0;
> > diff --git a/drivers/block/null_blk/null_blk.h b/drivers/block/null_blk/null_blk.h
> > index eb5972c50be8..94e524e7306a 100644
> > --- a/drivers/block/null_blk/null_blk.h
> > +++ b/drivers/block/null_blk/null_blk.h
> > @@ -67,6 +67,13 @@ enum {
> > NULL_Q_MQ = 2,
> > };
> >
> > +struct nullb_copy_token {
> > + char subsys[5];
> > + struct nullb *nullb;
> > + u64 sector_in;
> > + u64 sectors;
> > +};
> > +
> > struct nullb_device {
> > struct nullb *nullb;
> > struct config_item item;
>
> --
> Damien Le Moal
> Western Digital Research
>
>
Thank you,
Nitesh Shetty
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2023-03-29 15:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230327084154epcas5p2a1d8ee728610929fbba8c7757ad3193e@epcas5p2.samsung.com>
2023-03-27 8:40 ` [PATCH v8 0/9] Implement copy offload support Anuj Gupta
[not found] ` <CGME20230327084216epcas5p3945507ecd94688c40c29195127ddc54d@epcas5p3.samsung.com>
2023-03-27 8:40 ` [PATCH v8 1/9] block: Introduce queue limits for copy-offload support Anuj Gupta
2023-03-29 8:40 ` Damien Le Moal
2023-03-29 10:41 ` Nitesh Shetty
2023-03-29 12:24 ` Damien Le Moal
2023-03-29 12:34 ` Nitesh Shetty
[not found] ` <CGME20230327084226epcas5p28e667b25cbb5e4b0e884aa2ca89cbfff@epcas5p2.samsung.com>
2023-03-27 8:40 ` [PATCH v8 2/9] block: Add copy offload support infrastructure Anuj Gupta
2023-03-29 8:56 ` Damien Le Moal
[not found] ` <CGME20230327084235epcas5p495559f907ce39184da72a412c5691e43@epcas5p4.samsung.com>
2023-03-27 8:40 ` [PATCH v8 3/9] block: add emulation for copy Anuj Gupta
[not found] ` <CGME20230327084244epcas5p1b0ede867e558ff6faf258de3656a8aa4@epcas5p1.samsung.com>
2023-03-27 8:40 ` [PATCH v8 4/9] fs, block: copy_file_range for def_blk_ops for direct block device Anuj Gupta
2023-03-29 12:14 ` Christian Brauner
2023-03-29 12:42 ` Nitesh Shetty
2023-03-30 5:48 ` Christian Brauner
2023-03-30 15:21 ` Nitesh Shetty
2023-03-29 14:07 ` kernel test robot
2023-03-29 15:30 ` kernel test robot
[not found] ` <CGME20230327084254epcas5p4c5f324c1501062f743895273c302c0a4@epcas5p4.samsung.com>
2023-03-27 8:40 ` [PATCH v8 5/9] nvme: add copy offload support Anuj Gupta
[not found] ` <CGME20230327084303epcas5p22fdd3af683d3eb1b3f503bcf045f578a@epcas5p2.samsung.com>
2023-03-27 8:40 ` [PATCH v8 6/9] nvmet: add copy command support for bdev and file ns Anuj Gupta
2023-03-29 13:56 ` kernel test robot
2023-03-29 18:36 ` kernel test robot
[not found] ` <CGME20230327084312epcas5p377810b172aa6048519591518f8c308d0@epcas5p3.samsung.com>
2023-03-27 8:40 ` [PATCH v8 7/9] dm: Add support for copy offload Anuj Gupta
2023-03-29 8:59 ` Damien Le Moal
2023-03-29 12:12 ` Nitesh Shetty
[not found] ` <CGME20230327084322epcas5p12f01e676e47d3c8ba880f3f5d58999b4@epcas5p1.samsung.com>
2023-03-27 8:40 ` [PATCH v8 8/9] dm: Enable copy offload for dm-linear target Anuj Gupta
[not found] ` <CGME20230327084331epcas5p2510ed79d04fe3432c2ec84ce528745c6@epcas5p2.samsung.com>
2023-03-27 8:40 ` [PATCH v8 9/9] null_blk: add support for copy offload Anuj Gupta
2023-03-29 9:04 ` Damien Le Moal
2023-03-29 12:22 ` Nitesh Shetty [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230329122248.GD11932@green5 \
--to=nj.shetty@samsung.com \
--cc=agk@redhat.com \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dm-devel@redhat.com \
--cc=gost.dev@samsung.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=nitheshshetty@gmail.com \
--cc=sagi@grimberg.me \
--cc=snitzer@kernel.org \
--cc=vincent.fu@samsung.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).