linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: syzbot <syzbot+9cf75dc581fb4307d6dd@syzkaller.appspotmail.com>
Cc: adilger.kernel@dilger.ca, krisman@collabora.com,
	linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
	tytso@mit.edu
Subject: Re: [syzbot] [ext4?] general protection fault in utf8nlookup
Date: Wed, 20 Sep 2023 00:36:59 -0700	[thread overview]
Message-ID: <20230920073659.GC2739@sol.localdomain> (raw)
In-Reply-To: <0000000000001f0b970605c39a7e@google.com>

On Tue, Sep 19, 2023 at 10:25:22PM -0700, syzbot wrote:
> Hello,
> 
> syzbot found the following issue on:
> 
> HEAD commit:    e42bebf6db29 Merge tag 'efi-fixes-for-v6.6-1' of git://git..
> git tree:       upstream
> console+strace: https://syzkaller.appspot.com/x/log.txt?x=179f4a38680000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=df91a3034fe3f122
> dashboard link: https://syzkaller.appspot.com/bug?extid=9cf75dc581fb4307d6dd
> compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1374a174680000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=12b12928680000
> 
> Downloadable assets:
> disk image: https://storage.googleapis.com/syzbot-assets/14a6a5d23944/disk-e42bebf6.raw.xz
> vmlinux: https://storage.googleapis.com/syzbot-assets/98cc4c220388/vmlinux-e42bebf6.xz
> kernel image: https://storage.googleapis.com/syzbot-assets/6a1d09cf21bf/bzImage-e42bebf6.xz
> mounted in repro #1: https://storage.googleapis.com/syzbot-assets/37e5beb24789/mount_0.gz
> mounted in repro #2: https://storage.googleapis.com/syzbot-assets/f219a9e665e9/mount_8.gz
> 
> The issue was bisected to:
> 
> commit b81427939590450172716093dafdda8ef52e020f
> Author: Eric Biggers <ebiggers@google.com>
> Date:   Mon Aug 14 18:29:02 2023 +0000
> 
>     ext4: remove redundant checks of s_encoding
> 
> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=10852352680000
> final oops:     https://syzkaller.appspot.com/x/report.txt?x=12852352680000
> console output: https://syzkaller.appspot.com/x/log.txt?x=14852352680000

This report is expected for now, since the repro involves writing to the page
cache of a mounted block device.  For more information see
https://lore.kernel.org/linux-fsdevel/20230813001202.GE41642@sol.localdomain and
https://lore.kernel.org/linux-fsdevel/20230814182903.37267-2-ebiggers@kernel.org.
Also https://lore.kernel.org/linux-fsdevel/20230704122727.17096-1-jack@suse.cz
which will ultimately be the fix for this class of issue.

Note: the repro that syzkaller generated for this is very strange (even moreso
than usual for syzkaller repros...) because it replaces its "scratch space" at
address 0x20000000 with a different mapping, specifically a mapping for a file
that is mounted as a filesystem via loopback.  That makes "syscalls" have weird
side effects as a result of the repro writing parameters to the address that is
supposed to contain its scratch space.  I don't think this should be happening,
so I've opened https://github.com/google/syzkaller/issues/4216 for it.

- Eric

  reply	other threads:[~2023-09-20  7:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-20  5:25 [syzbot] [ext4?] general protection fault in utf8nlookup syzbot
2023-09-20  7:36 ` Eric Biggers [this message]
2023-09-20 11:20 ` [PATCH] unicode: add s_encoding null ptr check in utf8ncursor Edward AD
2023-09-20 19:37   ` Eric Biggers
2024-02-13  0:24 ` [syzbot] [ext4?] general protection fault in utf8nlookup syzbot
2024-02-13 10:42   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230920073659.GC2739@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=adilger.kernel@dilger.ca \
    --cc=krisman@collabora.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+9cf75dc581fb4307d6dd@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).