From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx3-rdu2.redhat.com ([66.187.233.73]:52520 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S2388621AbeG1BP7 (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Fri, 27 Jul 2018 21:15:59 -0400
From: David Howells <dhowells@redhat.com>
In-Reply-To: <21395.1532735340@warthog.procyon.org.uk>
References: <21395.1532735340@warthog.procyon.org.uk> <CAG48ez0SdSPkimsk-MW7oSQO-Y64X-LD4JXnuPsZXKuz=y1_Kg@mail.gmail.com> <153271267980.9458.7640156373438016898.stgit@warthog.procyon.org.uk> <153271291017.9458.7827028432894772673.stgit@warthog.procyon.org.uk>
Cc: dhowells@redhat.com, Jann Horn <jannh@google.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Linux API <linux-api@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-fsdevel@vger.kernel.org,
        kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 34/38] vfs: syscall: Add fsinfo() to query filesystem information [ver #10]
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <21745.1532735504.1@warthog.procyon.org.uk>
Content-Transfer-Encoding: 8BIT
Date: Sat, 28 Jul 2018 00:51:44 +0100
Message-ID: <21746.1532735504@warthog.procyon.org.uk>
To: unlisted-recipients:; (no To-header on input)
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

David Howells <dhowells@redhat.com> wrote:

> One thing I'm confused about is that fat has both a codepage and a charset and
> I'm not sure of the difference.

In fact, it's not clear that the codepage is actually used.

	warthog>git grep '[.>]codepage'
	fs/fat/inode.c: opts->codepage = fat_default_codepage;
	fs/fat/inode.c:                 opts->codepage = option;
	fs/fat/inode.c: sprintf(buf, "cp%d", sbi->options.codepage);

David