From: David Howells <dhowells@redhat.com>
To: Andrei Vagin <avagin@virtuozzo.com>
Cc: dhowells@redhat.com, Andrei Vagin <avagin@openvz.org>,
linux-fsdevel@vger.kernel.org, Andrei Vagin <avagin@gmail.com>
Subject: Re: [PATCH dhowells/mount-context] fs: don't call fs_context->free() from fsmount()
Date: Tue, 31 Jul 2018 21:56:45 +0100 [thread overview]
Message-ID: <22269.1533070605@warthog.procyon.org.uk> (raw)
In-Reply-To: <20180731173421.GA14809@outlook.office365.com>
Andrei Vagin <avagin@virtuozzo.com> wrote:
> > I can do this two ways: (1) stick a flag in the context that says if
> > ->free() needs calling, (2) make all the ->free() routines aware that they
> > may see the reset state. I think (1) is less error prone.
>
> Does it mean that fc->fs_type->init_fs_context() should not be called
> contexts which are created from fspick()?
No. I've put a flag in the context that is set when ->init_fs_context() is
called and cleared when ->free() is called. ->free() isn't called in the put
routine if the flag isn't set.
David
next prev parent reply other threads:[~2018-07-31 22:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 7:29 [PATCH dhowells/mount-context] fs: don't call fs_context->free() from fsmount() Andrei Vagin
2018-07-31 8:52 ` David Howells
2018-07-31 17:34 ` Andrei Vagin
2018-07-31 20:56 ` David Howells [this message]
2018-07-31 22:48 ` Andrei Vagin
2018-08-01 0:42 ` David Howells
2018-08-01 5:53 ` Andrei Vagin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22269.1533070605@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=avagin@gmail.com \
--cc=avagin@openvz.org \
--cc=avagin@virtuozzo.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).