From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: David Howells In-Reply-To: <20180709155618.GH30522@ZenIV.linux.org.uk> References: <20180709155618.GH30522@ZenIV.linux.org.uk> <20180708234630.GB700@sol.localdomain> <20180708210154.10423-1-ebiggers3@gmail.com> <31355.1531150319@warthog.procyon.org.uk> To: Al Viro Cc: dhowells@redhat.com, Eric Biggers , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH vfs/for-next 00/18] fs_context fixes MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <22922.1531153724.1@warthog.procyon.org.uk> Date: Mon, 09 Jul 2018 17:28:44 +0100 Message-ID: <22923.1531153724@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: Al Viro wrote: > Egads... *If* you go for bool here, why not > return (mnt->mnt_flags & MNT_READONLY) || sb_rdonly(mnt->mnt_sb); > and be done with that? Fair point; I'll do that when I get back later. David