From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:54568 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1729947AbeIRVHr (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Tue, 18 Sep 2018 17:07:47 -0400
From: David Howells <dhowells@redhat.com>
In-Reply-To: <20180918090722.GA463@jagdpanzerIV>
References: <20180918090722.GA463@jagdpanzerIV> <20180911220743.GA13208@roeck-us.net> <20180911174641.GA15149@roeck-us.net> <153313703562.13253.5766498657900728120.stgit@warthog.procyon.org.uk> <153313714181.13253.304098108512966976.stgit@warthog.procyon.org.uk> <27113.1536702746@warthog.procyon.org.uk> <32382.1536707855@warthog.procyon.org.uk> <20180911235403.GA10107@roeck-us.net>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: dhowells@redhat.com, Guenter Roeck <linux@roeck-us.net>,
        viro@zeniv.linux.org.uk, torvalds@linux-foundation.org,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 14/33] vfs: Implement a filesystem superblock creation/configuration context [ver #11]
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <23042.1537284879.1@warthog.procyon.org.uk>
Date: Tue, 18 Sep 2018 16:34:39 +0100
Message-ID: <23043.1537284879@warthog.procyon.org.uk>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> wrote:

>  static void do_emergency_remount_callback(struct super_block *sb)
>  {
>  	struct fs_context fc = {
> +		.ops		= &legacy_fs_context_ops,
>  		.purpose	= FS_CONTEXT_FOR_EMERGENCY_RO,
>  		.fs_type	= sb->s_type,
>  		.root		= sb->s_root,

Actually, we do need to call ->init_fs_context() or legacy_init_fs_context()
to set the ops pointer.

David