From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx3-rdu2.redhat.com ([66.187.233.73]:43376 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1726850AbeILCBs (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Tue, 11 Sep 2018 22:01:48 -0400
From: David Howells <dhowells@redhat.com>
In-Reply-To: <CANaxB-yqypZ50XoLL2mP1U_nDprqqBt1cbg_jSNDw7bjgr3mXw@mail.gmail.com>
References: <CANaxB-yqypZ50XoLL2mP1U_nDprqqBt1cbg_jSNDw7bjgr3mXw@mail.gmail.com> <CANaxB-yAhV9WW6gEBswPTH5R65wpRoxm_ygOn5Vj6Pzg2RSwLw@mail.gmail.com> <24102.1536697257@warthog.procyon.org.uk>
To: Andrei Vagin <avagin@gmail.com>
Cc: dhowells@redhat.com, linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [dhowells/mount-api] general protection fault in mqueue_get_tree
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2577.1536699641.1@warthog.procyon.org.uk>
Date: Tue, 11 Sep 2018 22:00:41 +0100
Message-ID: <2578.1536699641@warthog.procyon.org.uk>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Andrei Vagin <avagin@gmail.com> wrote:

> The ipc_namespace structure is big, so I am not sure about kzalloc().
> ns->mq_mnt can be initialized in mq_init_ns, it looks better than my
> previous patch.

I sincerely hope that ipc_namespace creation isn't a particularly hot path, so
I wouldn't've thought that preclearing the struct (which is nearly 2K in my
build) shouldn't add too much overhead.

David