From: David Howells <dhowells@redhat.com>
To: Richard Weinberger <richard@nod.at>
Cc: dhowells@redhat.com, viro@zeniv.linux.org.uk,
linux-block@vger.kernel.org,
squashfs-devel@lists.sourceforge.net,
Marek Vasut <marek.vasut@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
Nicolas Pitre <nico@linaro.org>,
Boris Brezillon <bbrezillon@kernel.org>,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Phillip Lougher <phillip@squashfs.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/6] Convert mount_single-using filesystems to fs_context
Date: Thu, 21 Mar 2019 17:06:25 +0000 [thread overview]
Message-ID: <26884.1553187985@warthog.procyon.org.uk> (raw)
In-Reply-To: <11178040.rrurhZOAV8@blindfold>
Richard Weinberger <richard@nod.at> wrote:
> Just gave it a try, jffs2 does not mount anymore. The problem is that you
> define an Opt_source in super.c, but never evaluate it ->
> jffs2_parse_param() returns -EINVAL.
Will fix.
> What I really don't get is the new logging stuff in
> include/linux/fs_context.h. printk() is already an overloaded beat, why
> another layer?
Because there are some patches that aren't upstream yet that allow you to read
these out through the file descriptor you control the mount process through
rather than them going into dmesg.
> The log output seems very odd to me:
> [ 13.117593] e MTD: Couldn't look up '/dev/mtd0': -15
>
> Please notice the "e" before MTD, first I though this is a memory
> corruption, but is your log level?!
Thanks - I'll fix that.
David
prev parent reply other threads:[~2019-03-21 17:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 11:50 [RFC PATCH 0/6] Convert mount_single-using filesystems to fs_context David Howells
2019-03-21 11:50 ` [RFC PATCH 1/6] mtd: Provide fs_context-aware mount_mtd() replacement David Howells
2019-03-21 11:50 ` [RFC PATCH 2/6] romfs: Convert to fs_context David Howells
2019-03-21 11:50 ` [RFC PATCH 3/6] cramfs: " David Howells
2019-03-21 11:50 ` [RFC PATCH 4/6] jffs2: " David Howells
2019-03-21 11:52 ` [RFC PATCH 0/6] Convert mount_single-using filesystems " David Howells
2019-03-21 12:48 ` Richard Weinberger
2019-03-21 15:12 ` David Howells
2019-03-21 15:16 ` David Howells
2019-03-21 15:41 ` Richard Weinberger
2019-03-21 15:45 ` David Howells
2019-03-21 16:34 ` Richard Weinberger
2019-03-21 17:06 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26884.1553187985@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=nico@linaro.org \
--cc=phillip@squashfs.org.uk \
--cc=richard@nod.at \
--cc=squashfs-devel@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).