From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21710C43381 for ; Mon, 18 Mar 2019 13:18:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E5D3B20850 for ; Mon, 18 Mar 2019 13:18:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726643AbfCRNSX (ORCPT ); Mon, 18 Mar 2019 09:18:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35688 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726271AbfCRNSX (ORCPT ); Mon, 18 Mar 2019 09:18:23 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 31E08308425A for ; Mon, 18 Mar 2019 13:18:23 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-17.rdu2.redhat.com [10.10.120.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id 564995C882; Mon, 18 Mar 2019 13:18:20 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20190317174027.15291-2-anprice@redhat.com> References: <20190317174027.15291-2-anprice@redhat.com> <20190317174027.15291-1-anprice@redhat.com> To: Andrew Price Cc: dhowells@redhat.com, cluster-devel@redhat.com, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 1/2] gfs2: Convert gfs2 to fs_context MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <28292.1552915099.1@warthog.procyon.org.uk> Date: Mon, 18 Mar 2019 13:18:19 +0000 Message-ID: <28293.1552915099@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Mon, 18 Mar 2019 13:18:23 +0000 (UTC) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Andrew Price wrote: > sget() is still used instead of sget_fc() as there doesn't seem to be an > obvious replacement for the bdev pointer propagation to the test/set > functions (yet?) Umm... What about the fs_context struct? Why can't that be used to propagate the bdev pointer? That's kind of what it's for... struct super_block *sget_fc( struct fs_context *fc, int (*test)(struct super_block *, struct fs_context *), int (*set)(struct super_block *, struct fs_context *)) It looks like you should be able to stash the bdev pointer in the gfs2_args struct. > + fsparam_s32 ("commit", Opt_commit), > + fsparam_s32 ("statfs_quantum", Opt_statfs_quantum), > + fsparam_s32 ("statfs_percent", Opt_statfs_percent), Why s32? Why not u32? David