From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DAA3C43331 for ; Fri, 6 Sep 2019 09:17:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E29622082C for ; Fri, 6 Sep 2019 09:17:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404113AbfIFJRr (ORCPT ); Fri, 6 Sep 2019 05:17:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46736 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728356AbfIFJRq (ORCPT ); Fri, 6 Sep 2019 05:17:46 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C7D774E924 for ; Fri, 6 Sep 2019 09:17:46 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-255.rdu2.redhat.com [10.10.120.255]) by smtp.corp.redhat.com (Postfix) with ESMTP id 19FB15D9D3; Fri, 6 Sep 2019 09:17:43 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <7020be46-f21f-bd05-71a5-cb2bc073596b@redhat.com> References: <7020be46-f21f-bd05-71a5-cb2bc073596b@redhat.com> To: Eric Sandeen Cc: dhowells@redhat.com, fsdevel Subject: Re: [PATCH] fs: fs_parser: remove fs_parameter_description name field MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <29445.1567761462.1@warthog.procyon.org.uk> Date: Fri, 06 Sep 2019 10:17:42 +0100 Message-ID: <29446.1567761462@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 06 Sep 2019 09:17:46 +0000 (UTC) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Eric Sandeen wrote: > There doesn't seem to be a strong reason to have another copy of the > filesystem name string in the fs_parameter_description structure; > it's easy enough to get the name from the fs_type, and using it > instead ensures consistency across messages (for example, > vfs_parse_fs_param() already uses fc->fs_type->name for the error > messages, because it doesn't have the fs_parameter_description). > > Signed-off-by: Eric Sandeen It was put there for fs_validate_description() to use. That checks both filesystem and LSM parameter descriptions. We could pass a name in to that function instead. David