From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:48534 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726343AbeHUMjW (ORCPT ); Tue, 21 Aug 2018 08:39:22 -0400 From: David Howells In-Reply-To: <20180820232910.GA3595@outlook.office365.com> References: <20180820232910.GA3595@outlook.office365.com> <20180810220027.2735-2-avagin@openvz.org> <20180810220027.2735-1-avagin@openvz.org> <16724.1533941730@warthog.procyon.org.uk> To: Andrei Vagin Cc: dhowells@redhat.com, Andrei Vagin , linux-fsdevel@vger.kernel.org, Andrei Vagin Subject: Re: [PATCH dhowells/mount-api 2/2] selftests: implement a test for a new mount API MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <29862.1534843199.1@warthog.procyon.org.uk> Date: Tue, 21 Aug 2018 10:19:59 +0100 Message-ID: <29863.1534843199@warthog.procyon.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Andrei Vagin wrote: > > > +static const char dev[] = "s test_fsopen_123"; > > > > Did you mean to prefix that with "s "? > > "s " means "source" here, it is an effect of a previous version of this > interface > > https://lwn.net/Articles/753473/ Yeah, well Linus objected, so we're not using write() now. So the key string given to fsconfig() now indicates this information (ie. "source"). David