From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9B86C0650F for ; Fri, 2 Aug 2019 22:32:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9CC4320B7C for ; Fri, 2 Aug 2019 22:32:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564785167; bh=z6ytUlp+CIECyVYgzsmKAgNAlD3y+8CHq71PuCQ0D+c=; h=Subject:From:To:Cc:Date:In-Reply-To:References:List-ID:From; b=EPo3mRs7M451grjuM4XkUiYjcmWODVccueEK3VougyEXvvjzwxjCO5zqyjWghP9Hh Y6dFmyKDWRSVlWl7HOvO2CEiSbqn1RWeI9XsnxRd3VJbgFkykcWtS+lbBjwO2LIo/l zdP0nNIpXjFv/ynrFVIoZ+XTric0Iy/FSDfGC+cM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392393AbfHBWcj (ORCPT ); Fri, 2 Aug 2019 18:32:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:44032 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729919AbfHBWci (ORCPT ); Fri, 2 Aug 2019 18:32:38 -0400 Received: from tleilax.poochiereds.net (cpe-71-70-156-158.nc.res.rr.com [71.70.156.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 58F57206A3; Fri, 2 Aug 2019 22:32:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564785158; bh=z6ytUlp+CIECyVYgzsmKAgNAlD3y+8CHq71PuCQ0D+c=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=cpjIBy8JqGDmfo2YvJ1zHX2H3F5SzV7XyBEUvKOoDGfZiHGtVeJHlsiNF8f/o/lw/ 1IriX/50tm1jxxFU6BHxnU7AmYr31cK1qfEIW7FiUI67JvLd42gEz50jymZEZTSESa 2e28o/zwwAXm5Iq/SkAmipJbFc8z+f7/iU9PnXtA= Message-ID: <2f0d5993e9731808b73b0018f5fc4b3335fc6373.camel@kernel.org> Subject: Re: [PATCH 03/34] net/ceph: convert put_page() to put_user_page*() From: Jeff Layton To: john.hubbard@gmail.com, Andrew Morton Cc: Christoph Hellwig , Dan Williams , Dave Chinner , Dave Hansen , Ira Weiny , Jan Kara , Jason Gunthorpe , =?ISO-8859-1?Q?J=E9r=F4me?= Glisse , LKML , amd-gfx@lists.freedesktop.org, ceph-devel@vger.kernel.org, devel@driverdev.osuosl.org, devel@lists.orangefs.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-crypto@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-media@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-xfs@vger.kernel.org, netdev@vger.kernel.org, rds-devel@oss.oracle.com, sparclinux@vger.kernel.org, x86@kernel.org, xen-devel@lists.xenproject.org, John Hubbard , Ilya Dryomov , Sage Weil , "David S . Miller" Date: Fri, 02 Aug 2019 18:32:33 -0400 In-Reply-To: <20190802022005.5117-4-jhubbard@nvidia.com> References: <20190802022005.5117-1-jhubbard@nvidia.com> <20190802022005.5117-4-jhubbard@nvidia.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.4 (3.32.4-1.fc30) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, 2019-08-01 at 19:19 -0700, john.hubbard@gmail.com wrote: > From: John Hubbard > > For pages that were retained via get_user_pages*(), release those pages > via the new put_user_page*() routines, instead of via put_page() or > release_pages(). > > This is part a tree-wide conversion, as described in commit fc1d8e7cca2d > ("mm: introduce put_user_page*(), placeholder versions"). > > Cc: Ilya Dryomov > Cc: Sage Weil > Cc: David S. Miller > Cc: ceph-devel@vger.kernel.org > Cc: netdev@vger.kernel.org > Signed-off-by: John Hubbard > --- > net/ceph/pagevec.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/net/ceph/pagevec.c b/net/ceph/pagevec.c > index 64305e7056a1..c88fff2ab9bd 100644 > --- a/net/ceph/pagevec.c > +++ b/net/ceph/pagevec.c > @@ -12,13 +12,7 @@ > > void ceph_put_page_vector(struct page **pages, int num_pages, bool dirty) > { > - int i; > - > - for (i = 0; i < num_pages; i++) { > - if (dirty) > - set_page_dirty_lock(pages[i]); > - put_page(pages[i]); > - } > + put_user_pages_dirty_lock(pages, num_pages, dirty); > kvfree(pages); > } > EXPORT_SYMBOL(ceph_put_page_vector); This patch looks sane enough. Assuming that the earlier patches are OK: Acked-by: Jeff Layton