archive mirror
 help / color / mirror / Atom feed
From: John Hubbard <>
To: Ira Weiny <>
Cc: "Andrew Morton" <>,
	"Christoph Hellwig" <>,
	"Dan Williams" <>,
	"Dave Chinner" <>, "Jan Kara" <>,
	"Jason Gunthorpe" <>,
	"Jérôme Glisse" <>,
	"Vlastimil Babka" <>,
	LKML <>,,,
Subject: Re: [PATCH v2 0/3] mm/gup: introduce vaddr_pin_pages_remote(), FOLL_PIN
Date: Thu, 22 Aug 2019 17:36:07 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 8/22/19 5:24 PM, Ira Weiny wrote:
> On Tue, Aug 20, 2019 at 09:07:24PM -0700, John Hubbard wrote:
>> Hi Ira,
>> This is for your tree. I'm dropping the RFC because this aspect is
>> starting to firm up pretty well.
>> I've moved FOLL_PIN inside the vaddr_pin_*() routines, and moved
>> FOLL_LONGTERM outside, based on our recent discussions. This is
>> documented pretty well within the patches.
>> Note that there are a lot of references in comments and commit
>> logs, to vaddr_pin_pages(). We'll want to catch all of those if
>> we rename that. I am pushing pretty hard to rename it to
>> vaddr_pin_user_pages().
>> v1 of this may be found here:
> I am really sorry about this...
> I think it is fine to pull these in...  There are some nits which are wrong but
> I think with the XDP complication and Daves' objection I think the vaddr_pin
> information is going to need reworking.  So the documentation there is probably
> wrong.  But until we know what it is going to be we should just take this.

Sure, I was thinking the same thing: FOLL_PIN is clearing up, but vaddr_pin_pages() 
is still under heavy discussion.

> Do you have a branch with this on it?

Yes, it's on: , branch: vaddr_FOLL_PIN_next

> The patches don't seem to apply.  Looks like they got corrupted somewhere...

Lately I'm trying out outgoing servers for git-send-email, so I'm 
still nervous about potential email-based patch problems. I suspect, though,
that it's really just a "must be on exactly the right commit in order to apply"
situation. Please let me know, so I can make any corrections necessary on this end.

John Hubbard

      reply	other threads:[~2019-08-23  0:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-21  4:07 John Hubbard
2019-08-21  4:07 ` [PATCH v2 1/3] For Ira: tiny formatting tweak to kerneldoc John Hubbard
2019-08-21  4:07 ` [PATCH v2 2/3] mm/gup: introduce FOLL_PIN flag for get_user_pages() John Hubbard
2019-08-21  4:07 ` [PATCH v2 3/3] mm/gup: introduce vaddr_pin_pages_remote(), and invoke it John Hubbard
2019-08-23  0:24 ` [PATCH v2 0/3] mm/gup: introduce vaddr_pin_pages_remote(), FOLL_PIN Ira Weiny
2019-08-23  0:36   ` John Hubbard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2 0/3] mm/gup: introduce vaddr_pin_pages_remote(), FOLL_PIN' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).