From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97138C4320A for ; Fri, 23 Jul 2021 01:35:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7507860EBD for ; Fri, 23 Jul 2021 01:35:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233112AbhGWAzY (ORCPT ); Thu, 22 Jul 2021 20:55:24 -0400 Received: from mga02.intel.com ([134.134.136.20]:55328 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232892AbhGWAzX (ORCPT ); Thu, 22 Jul 2021 20:55:23 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10053"; a="198987750" X-IronPort-AV: E=Sophos;i="5.84,262,1620716400"; d="scan'208";a="198987750" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2021 18:35:54 -0700 X-IronPort-AV: E=Sophos;i="5.84,262,1620716400"; d="scan'208";a="433364508" Received: from rongch2-mobl.ccr.corp.intel.com (HELO [10.249.174.9]) ([10.249.174.9]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2021 18:35:51 -0700 Subject: Re: [PATCH v3 14/15] samples: Add fs error monitoring example To: Gabriel Krisman Bertazi Cc: Dan Carpenter , kernel test robot , amir73il@gmail.com, kbuild-all@lists.01.org, djwong@kernel.org, tytso@mit.edu, david@fromorbit.com, jack@suse.com, dhowells@redhat.com, khazhy@google.com, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org References: <20210629191035.681913-15-krisman@collabora.com> <202106301048.BainWUsk-lkp@intel.com> <87mtqicqux.fsf@collabora.com> <20210720194955.GH25548@kadam> <4313fff4-343a-2937-3a97-c5da860827b1@intel.com> <874kcmb9zs.fsf@collabora.com> From: "Chen, Rong A" Message-ID: <31d5c954-0188-e91f-4444-faeb6dc1339a@intel.com> Date: Fri, 23 Jul 2021 09:35:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <874kcmb9zs.fsf@collabora.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 7/23/2021 12:15 AM, Gabriel Krisman Bertazi wrote: > "Chen, Rong A" writes: > >> Hi Gabriel, >> >> On 7/21/2021 3:49 AM, Dan Carpenter wrote: >>> On Mon, Jul 19, 2021 at 10:36:54AM -0400, Gabriel Krisman Bertazi >>> wrote: >>>> kernel test robot writes: >>>> >>>>> Hi Gabriel, >>>>> >>>>> I love your patch! Yet something to improve: >>>>> >>>>> [auto build test ERROR on ext3/fsnotify] >>>>> [also build test ERROR on ext4/dev linus/master v5.13 next-20210629] >>>>> [cannot apply to tytso-fscrypt/master] >>>>> [If your patch is applied to the wrong git tree, kindly drop us a note. >>>>> And when submitting patch, we suggest to use '--base' as documented in >>>>> https://git-scm.com/docs/git-format-patch ] >>>>> >>>>> url: https://github.com/0day-ci/linux/commits/Gabriel-Krisman-Bertazi/File-system-wide-monitoring/20210630-031347 >>>>> base: https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git fsnotify >>>>> config: arm64-allyesconfig (attached as .config) >>>>> compiler: aarch64-linux-gcc (GCC) 9.3.0 >>>>> reproduce (this is a W=1 build): >>>>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >>>>> chmod +x ~/bin/make.cross >>>>> # https://github.com/0day-ci/linux/commit/746524d8db08a041fed90e41b15c8e8ca69cb22d >>>>> git remote add linux-review https://github.com/0day-ci/linux >>>>> git fetch --no-tags linux-review Gabriel-Krisman-Bertazi/File-system-wide-monitoring/20210630-031347 >>>>> git checkout 746524d8db08a041fed90e41b15c8e8ca69cb22d >>>>> # save the attached .config to linux build tree >>>>> mkdir build_dir >>>>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash samples/ >>>>> >>>>> If you fix the issue, kindly add following tag as appropriate >>>>> Reported-by: kernel test robot >>>>> >>>>> All errors (new ones prefixed by >>): >>>>> >>>>>>> samples/fanotify/fs-monitor.c:7:10: fatal error: errno.h: No such file or directory >>>>> 7 | #include >>>>> | ^~~~~~~~~ >>>>> compilation terminated. >>>> >>>> Hi Dan, >>>> >>>> I'm not sure what's the proper fix here. Looks like 0day is not using >>>> cross system libraries when building this user space code. Should I do >>>> something special to silent it? >> >> It seems need extra libraries for arm64, we'll disable CONFIG_SAMPLES to >> avoid reporting this error. > > There are kernel space code in samples/ that still benefit from the test > robot. See ftrace/ftrace-direct-too.c for one instance. > > Perhaps it can be disabled just for userprogs-* Makefile entries in > samples/ ? > we'll still test samples on arch x86_64, is there a simple way to disable userprogs-* cases? we don't want to edit kernel code. Best Regards, Rong Chen