From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2E0CC433B4 for ; Sun, 25 Apr 2021 07:49:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EE1461451 for ; Sun, 25 Apr 2021 07:49:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229579AbhDYHug (ORCPT ); Sun, 25 Apr 2021 03:50:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:45197 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229504AbhDYHug (ORCPT ); Sun, 25 Apr 2021 03:50:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619336996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Im4R7SZHjo22hPEh3n8+YlircfIMQ1gHe/V7o9XQRXw=; b=AGILV2W8TLniokq/RYWAP8mm4nlnZbKQhNBPwgpPrBdYUMzreJqiyrSMbNaTXBYjXPkeHJ uSkwQ5m9WIha5d5ayLV/Nu+yrsdRhYmLDzdDwXlEmjDTd5Ili24TIFMy9BqTVFugFFw9Np /y9t+2SpJdM3iYDbMsVQS4GLaKKLAgU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-352-hCefhymWP_6ERB9w6VsZvw-1; Sun, 25 Apr 2021 03:49:54 -0400 X-MC-Unique: hCefhymWP_6ERB9w6VsZvw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 625F58189C8; Sun, 25 Apr 2021 07:49:53 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-112-124.rdu2.redhat.com [10.10.112.124]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9138019C46; Sun, 25 Apr 2021 07:49:52 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20210327035019.GG1719932@casper.infradead.org> <20210201130800.GP308988@casper.infradead.org> <2884397.1616584210@warthog.procyon.org.uk> <1507388.1616833898@warthog.procyon.org.uk> <20210327135659.GH1719932@casper.infradead.org> <20210327155630.GJ1719932@casper.infradead.org> <1720948.1617010659@warthog.procyon.org.uk> <1268214.1618326494@warthog.procyon.org.uk > <1612829.1618587694@warthog.procyon.org.uk> To: Mike Marshall Cc: dhowells@redhat.com, Matthew Wilcox , linux-fsdevel Subject: Re: [RFC PATCH v2] implement orangefs_readahead MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3365452.1619336991.1@warthog.procyon.org.uk> Date: Sun, 25 Apr 2021 08:49:51 +0100 Message-ID: <3365453.1619336991@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Mike Marshall wrote: > >> I wonder if you should use iov_length(&iter) > > iov_length has two arguments. The first one would maybe be iter.iov and > the second one would be... ? Sorry, I meant iov_iter_count(&iter). I'll look at the other things next week. Is it easy to set up an orangefs client and server? David