archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <>
To: Matthew Wilcox <>
Cc: linux-fsdevel <>,
	"" <>,
	Alexander Viro <>,
	Jann Horn <>
Subject: Re: [PATCH] fs: align IOCB_* flags with RWF_* flags
Date: Mon, 7 Sep 2020 20:12:07 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 9/7/20 2:15 PM, Matthew Wilcox wrote:
> On Mon, Aug 31, 2020 at 12:08:10PM -0600, Jens Axboe wrote:
>> We have a set of flags that are shared between the two and inherired
>> in kiocb_set_rw_flags(), but we check and set these individually.
>> Reorder the IOCB flags so that the bottom part of the space is synced
>> with the RWF flag space, and then we can do them all in one mask and
>> set operation.
>> The only exception is RWF_SYNC, which needs to mark IOCB_SYNC and
>> IOCB_DSYNC. Do that one separately.
>> This shaves 15 bytes of text from kiocb_set_rw_flags() for me.
>> Signed-off-by: Jens Axboe <>
> Suggested-by: Matthew Wilcox (Oracle) <>


Jens Axboe

      reply	other threads:[~2020-09-08  2:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31 18:08 [PATCH] fs: align IOCB_* flags with RWF_* flags Jens Axboe
2020-09-07 19:43 ` Jens Axboe
2020-09-07 20:15 ` Matthew Wilcox
2020-09-08  2:12   ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).