From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90A02C04E87 for ; Wed, 15 May 2019 08:38:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6EFFA2082E for ; Wed, 15 May 2019 08:38:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726124AbfEOIiH (ORCPT ); Wed, 15 May 2019 04:38:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39098 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725933AbfEOIiH (ORCPT ); Wed, 15 May 2019 04:38:07 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DF0FB59454; Wed, 15 May 2019 08:38:06 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CB90F64422; Wed, 15 May 2019 08:38:06 +0000 (UTC) Received: from zmail21.collab.prod.int.phx2.redhat.com (zmail21.collab.prod.int.phx2.redhat.com [10.5.83.24]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A90F818089C9; Wed, 15 May 2019 08:38:06 +0000 (UTC) Date: Wed, 15 May 2019 04:38:06 -0400 (EDT) From: Pankaj Gupta To: Dan Williams Cc: snitzer@redhat.com, stable@vger.kernel.org, Jan Kara , Ira Weiny , Dave Jiang , Keith Busch , Matthew Wilcox , Vishal Verma , Heiko Carstens , Martin Schwidefsky , linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org, dm-devel@redhat.com, linux-kernel@vger.kernel.org Message-ID: <34965939.28870107.1557909486195.JavaMail.zimbra@redhat.com> In-Reply-To: <155789172402.748145.11853718580748830476.stgit@dwillia2-desk3.amr.corp.intel.com> References: <155789172402.748145.11853718580748830476.stgit@dwillia2-desk3.amr.corp.intel.com> Subject: Re: [PATCH] dax: Arrange for dax_supported check to span multiple devices MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.65.16.80, 10.4.195.16] Thread-Topic: Arrange for dax_supported check to span multiple devices Thread-Index: DFYzSsTeR2lh7L09oG6Kp02APnkUKQ== X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 15 May 2019 08:38:07 +0000 (UTC) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org > > Pankaj reports that starting with commit ad428cdb525a "dax: Check the > end of the block-device capacity with dax_direct_access()" device-mapper > no longer allows dax operation. This results from the stricter checks in > __bdev_dax_supported() that validate that the start and end of a > block-device map to the same 'pagemap' instance. > > Teach the dax-core and device-mapper to validate the 'pagemap' on a > per-target basis. This is accomplished by refactoring the > bdev_dax_supported() internals into generic_fsdax_supported() which > takes a sector range to validate. Consequently generic_fsdax_supported() > is suitable to be used in a device-mapper ->iterate_devices() callback. > A new ->dax_supported() operation is added to allow composite devices to > split and route upper-level bdev_dax_supported() requests. > > Fixes: ad428cdb525a ("dax: Check the end of the block-device...") > Cc: > Cc: Jan Kara > Cc: Ira Weiny > Cc: Dave Jiang > Cc: Mike Snitzer > Cc: Keith Busch > Cc: Matthew Wilcox > Cc: Vishal Verma > Cc: Heiko Carstens > Cc: Martin Schwidefsky > Reported-by: Pankaj Gupta > Signed-off-by: Dan Williams Thank you for the patch. Looks good to me. I also tested the patch and it works well. Reviewed-and-Tested-by: Pankaj Gupta Best regards, Pankaj