From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 752BCC1975A for ; Wed, 25 Mar 2020 15:52:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5009520772 for ; Wed, 25 Mar 2020 15:52:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="uicKA8wI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727854AbgCYPwE (ORCPT ); Wed, 25 Mar 2020 11:52:04 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:36288 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727774AbgCYPwE (ORCPT ); Wed, 25 Mar 2020 11:52:04 -0400 Received: by mail-lj1-f193.google.com with SMTP id g12so3026692ljj.3 for ; Wed, 25 Mar 2020 08:52:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FFKgDeHvhTCS00AQN8L5xpmPeeM6E1oKLK7azqnWDiE=; b=uicKA8wIvWFlXoj/N3LEYBm1C4A3V4P9iw9tec/gYSHrhStzUBQCHg9572Xte1kjgR ThMBTvZUPKiWKz7FpDL5FpZdKIk2YCmk4xT9mv8vXzDYbG7BnewAeqmTmjbMblvWal3H mWL8hgD8rxlqA3cc+cD7G6ybnkogU1aJ7AGejI0PI8JR5OHaQ8Yinse9H4h+GK2Hb1A4 AO25iODgSANaemv90W5sSFYFQjzOpxBoKLIe96Vf8WjB/zrqJX1NEJY7yq750pQkaqOk 1+9OYeGLNZxl0e6F3esYfat8n9CQbuKfwTbzDvu3Chf0eeKLqiEo59Jx1mNdOEbnZcqK 7RZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=FFKgDeHvhTCS00AQN8L5xpmPeeM6E1oKLK7azqnWDiE=; b=E6iExGxCb0rhywBPg63u6EmP3LXHOekVnBQk1Hhb6SwNTfl5/Zf/g0ST4hZ+uYzc/R Yp4UC9nsc+MoJ8V4ccsCW/nvrnoPzvN/l1R54VNow25aYWM3oxPQxHlZLeTb/pVFJRj9 GMyb1Z62OsLP9qeUDvjOUPmoGkZAqtU8PtxNWZbVMM3RT2eq2kZd3tv+YVQCzoKTc4KJ mLKfzexap5EbhauX6puY2dReok6a7OhNcJzhCpSrzGy0mWai57to+FDDMyBBKjsnZ48x wAD5y8+v9cMcO0A929fftvYtzz/KwOaWo8Ywg3ilri0U0B7J0xOpYisRk9+UDF9sTQZb eO0Q== X-Gm-Message-State: AGi0PublS91JnJk8M/f87xTCkrhNjO6P5U0VHGgh4DvtDyzdbKVXuxFA LOExgX8X1y8eGYtwWQxXt6p3Rw== X-Google-Smtp-Source: ADFU+vv75ZUwXg2vEi4sa3vjU/XvBmaxBeQGnk0gRxgFefclx3FSltiYeD1SYorsoysNlfqIA2nFcA== X-Received: by 2002:a2e:964e:: with SMTP id z14mr2510095ljh.44.1585151522265; Wed, 25 Mar 2020 08:52:02 -0700 (PDT) Received: from wasted.cogentembedded.com ([2a00:1fa0:4678:2dac:733f:487d:7a84:7bac]) by smtp.gmail.com with ESMTPSA id l21sm275175lfh.63.2020.03.25.08.52.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Mar 2020 08:52:01 -0700 (PDT) Subject: Re: [PATCH 1/4] ubifs: remove broken lazytime support To: Christoph Hellwig , Theodore Ts'o , Jaegeuk Kim , Chao Yu , Al Viro , Richard Weinberger , linux-xfs@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org References: <20200325122825.1086872-1-hch@lst.de> <20200325122825.1086872-2-hch@lst.de> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <3771d2fd-b563-b74d-491b-e2bab9242126@cogentembedded.com> Date: Wed, 25 Mar 2020 18:51:59 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20200325122825.1086872-2-hch@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hello! On 03/25/2020 03:28 PM, Christoph Hellwig wrote: > When "ubifs: introduce UBIFS_ATIME_SUPPORT to ubifs" introduces atime > support to ubifs, it also lazytime support, but that support is ^ includes? > terminally broken, as it causes mark_inode_dirty_sync to be called from > __writeback_single_inode, which will then trigger the locking assert > in ubifs_dirty_inode. Just remove this broken support for now, it can > be readded later, especially as some infrastructure changes should > make that easier soon. > > Fixes: 8c1c5f263833 ("ubifs: introduce UBIFS_ATIME_SUPPORT to ubifs") > Signed-off-by: Christoph Hellwig [...] MBR, Sergei