From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E880C433DF for ; Tue, 13 Oct 2020 15:21:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3023C2491C for ; Tue, 13 Oct 2020 15:21:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="VxbGTR1M" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731132AbgJMPVh (ORCPT ); Tue, 13 Oct 2020 11:21:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726657AbgJMPVh (ORCPT ); Tue, 13 Oct 2020 11:21:37 -0400 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54B6EC0613D0; Tue, 13 Oct 2020 08:21:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=5RL4Y+hsa8aijqpStulF+xXzWubzL8B4yk2Fwjc3puo=; b=VxbGTR1MRa0lyYvCn2XYCQoIUA SYkNUtyIZATMjcJrN5/uV+8SspHQCzZaGETmNyW9Pg+rywr4yDiFJw3LzLQevPdiSJZ+SMb+G2cGD B1gqrapcFGTbo+lqOmRhbheXXtxBQDozkaojPadl9V6ZWrop+MucS6hywmlGtnF7D/VvYyEOIqUKT ho3u3BD80oYa/KynV49mV2fXVSXA4JqGQvnzlv9av/u6nnCDHDeT8MTgvU4jHl3MYhXrOIoXSAU6s m3jKdUquoJ0e/C/aiW/v8uY4P4iFejWiO6QX0C+TYmWYcAVl6u87JbhqgpocQ40T6Keyqn/J/nFhs EBo52dMQ==; Received: from [2601:1c0:6280:3f0::507c] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSM7E-0002Rr-P6; Tue, 13 Oct 2020 15:21:29 +0000 Subject: Re: [External] Re: [PATCH] mm: proc: add Sock to /proc/meminfo To: Mike Rapoport Cc: Muchun Song , Eric Dumazet , Eric Dumazet , Cong Wang , Greg KH , rafael@kernel.org, "Michael S. Tsirkin" , Jason Wang , David Miller , Jakub Kicinski , Alexey Dobriyan , Andrew Morton , Alexey Kuznetsov , Hideaki YOSHIFUJI , Steffen Klassert , Herbert Xu , Shakeel Butt , Will Deacon , Michal Hocko , Roman Gushchin , Neil Brown , Sami Tolvanen , "Kirill A. Shutemov" , Feng Tang , Paolo Abeni , Willem de Bruijn , Florian Westphal , gustavoars@kernel.org, Pablo Neira Ayuso , Dexuan Cui , Jakub Sitnicki , Peter Zijlstra , Christian Brauner , "Eric W. Biederman" , Thomas Gleixner , dave@stgolabs.net, Michel Lespinasse , Jann Horn , chenqiwu@xiaomi.com, christophe.leroy@c-s.fr, Minchan Kim , Martin KaFai Lau , Alexei Starovoitov , Daniel Borkmann , Miaohe Lin , Kees Cook , LKML , virtualization@lists.linux-foundation.org, Linux Kernel Network Developers , linux-fsdevel , linux-mm , Michael Kerrisk References: <20201010103854.66746-1-songmuchun@bytedance.com> <9262ea44-fc3a-0b30-54dd-526e16df85d1@gmail.com> <20201013080906.GD4251@kernel.org> <20201013151215.GG4251@kernel.org> From: Randy Dunlap Message-ID: <3aa9ff1a-e04f-517c-5ebb-2c27804c143a@infradead.org> Date: Tue, 13 Oct 2020 08:21:13 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201013151215.GG4251@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 10/13/20 8:12 AM, Mike Rapoport wrote: > On Tue, Oct 13, 2020 at 07:43:59AM -0700, Randy Dunlap wrote: >> On 10/13/20 1:09 AM, Mike Rapoport wrote: >>> On Mon, Oct 12, 2020 at 05:53:01PM +0800, Muchun Song wrote: >>>> On Mon, Oct 12, 2020 at 5:24 PM Eric Dumazet wrote: >>>>> >>>>> On 10/12/20 10:39 AM, Muchun Song wrote: >>>>>> On Mon, Oct 12, 2020 at 3:42 PM Eric Dumazet wrote: >>>> >>>> We are not complaining about TCP using too much memory, but how do >>>> we know that TCP uses a lot of memory. When I firstly face this problem, >>>> I do not know who uses the 25GB memory and it is not shown in the /proc/meminfo. >>>> If we can know the amount memory of the socket buffer via /proc/meminfo, we >>>> may not need to spend a lot of time troubleshooting this problem. Not everyone >>>> knows that a lot of memory may be used here. But I believe many people >>>> should know /proc/meminfo to confirm memory users. >>> >>> If I undestand correctly, the problem you are trying to solve is to >>> simplify troubleshooting of memory usage for people who may not be aware >>> that networking stack can be a large memory consumer. >>> >>> For that a paragraph in 'man 5 proc' maybe a good start: >>> >>> >From ddbcf38576d1a2b0e36fe25a27350d566759b664 Mon Sep 17 00:00:00 2001 >>> From: Mike Rapoport >>> Date: Tue, 13 Oct 2020 11:07:35 +0300 >>> Subject: [PATCH] proc.5: meminfo: add not anout network stack memory >>> consumption >>> >>> Signed-off-by: Mike Rapoport >>> --- >>> man5/proc.5 | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/man5/proc.5 b/man5/proc.5 >>> index ed309380b..8414676f1 100644 >>> --- a/man5/proc.5 >>> +++ b/man5/proc.5 >>> @@ -3478,6 +3478,14 @@ Except as noted below, >>> all of the fields have been present since at least Linux 2.6.0. >>> Some fields are displayed only if the kernel was configured >>> with various options; those dependencies are noted in the list. >>> +.IP >>> +Note that significant part of memory allocated by the network stack >>> +is not accounted in the file. >>> +The memory consumption of the network stack can be queried >>> +using >>> +.IR /proc/net/sockstat >>> +or >>> +.BR ss (8) >>> .RS >>> .TP >>> .IR MemTotal " %lu" >> >> Hi Mike, >> >> Could you tell us what units those values are in? >> or is that already explained somewhere else? > > It is described a few lines above and anyway, "MemTotal" is a part of > the diff context ;-) with no units AFAICT. But I was unclear. I wasn't referring to /proc/meminfo, but instead to /proc/net/sockstat and its units: sockets: used 1224 TCP: inuse 11 orphan 1 tw 1 alloc 26 mem 3 UDP: inuse 4 mem 2 UDPLITE: inuse 0 RAW: inuse 0 FRAG: inuse 0 memory 0 E.g., for TCP and UDP, are those socket counts or some unit of memory? If units of memory, what unit size? thanks. -- ~Randy