linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: "adobriyan@gmail.com" <adobriyan@gmail.com>,
	"corbet@lwn.net" <corbet@lwn.net>,
	"mchehab+huawei@kernel.org" <mchehab+huawei@kernel.org>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] doc: filesystems: proc: Fix literal blocks
Date: Wed, 15 Jul 2020 20:47:03 +0000	[thread overview]
Message-ID: <3d80a1ae-ba46-1840-a4a4-4046413d1c1c@alliedtelesis.co.nz> (raw)
In-Reply-To: <20200714090644.13011-2-chris.packham@alliedtelesis.co.nz>

Hi Jon,

On 14/07/20 9:06 pm, Chris Packham wrote:
> Sphinx complains
>
>    Documentation/filesystems/proc.rst:2194: WARNING: Inconsistent literal block quoting.
>
> Update the command line snippets to be properly formed literal blocks.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
>   Documentation/filesystems/proc.rst | 38 +++++++++++++++++-------------
>   1 file changed, 21 insertions(+), 17 deletions(-)
>
> diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
> index 53a0230a08e2..6027dc94755f 100644
> --- a/Documentation/filesystems/proc.rst
> +++ b/Documentation/filesystems/proc.rst
> @@ -2190,25 +2190,27 @@ mountpoints within the same namespace.
>   
>   ::
>   
> -# grep ^proc /proc/mounts
> -proc /proc proc rw,relatime,hidepid=2 0 0
> + # grep ^proc /proc/mounts
> + proc /proc proc rw,relatime,hidepid=2 0 0
>   
> -# strace -e mount mount -o hidepid=1 -t proc proc /tmp/proc
> -mount("proc", "/tmp/proc", "proc", 0, "hidepid=1") = 0
> -+++ exited with 0 +++
> + # strace -e mount mount -o hidepid=1 -t proc proc /tmp/proc
> + mount("proc", "/tmp/proc", "proc", 0, "hidepid=1") = 0
> + +++ exited with 0 +++
>   
> -# grep ^proc /proc/mounts
> -proc /proc proc rw,relatime,hidepid=2 0 0
> -proc /tmp/proc proc rw,relatime,hidepid=2 0 0
> + # grep ^proc /proc/mounts
> + proc /proc proc rw,relatime,hidepid=2 0 0
> + proc /tmp/proc proc rw,relatime,hidepid=2 0 0
>   
>   and only after remounting procfs mount options will change at all
>   mountpoints.
>   
> -# mount -o remount,hidepid=1 -t proc proc /tmp/proc
> +::
> +
> + # mount -o remount,hidepid=1 -t proc proc /tmp/proc
>   
> -# grep ^proc /proc/mounts
> -proc /proc proc rw,relatime,hidepid=1 0 0
> -proc /tmp/proc proc rw,relatime,hidepid=1 0 0
> + # grep ^proc /proc/mounts
> + proc /proc proc rw,relatime,hidepid=1 0 0
> + proc /tmp/proc proc rw,relatime,hidepid=1 0 0
>   
>   This behavior is different from the behavior of other filesystems.
>   
> @@ -2217,8 +2219,10 @@ creates a new procfs instance. Mount options affect own procfs instance.
>   It means that it became possible to have several procfs instances
>   displaying tasks with different filtering options in one pid namespace.
>   
> -# mount -o hidepid=invisible -t proc proc /proc
> -# mount -o hidepid=noaccess -t proc proc /tmp/proc
> -# grep ^proc /proc/mounts
> -proc /proc proc rw,relatime,hidepid=invisible 0 0
> -proc /tmp/proc proc rw,relatime,hidepid=noaccess 0 0
> +::
> +
> + # mount -o hidepid=invisible -t proc proc /proc
> + # mount -o hidepid=noaccess -t proc proc /tmp/proc
> + # grep ^proc /proc/mounts
> + proc /proc proc rw,relatime,hidepid=invisible 0 0
> + proc /tmp/proc proc rw,relatime,hidepid=noaccess 0 0

Looks like Mauro also fixed this so this can be dropped too.

  parent reply	other threads:[~2020-07-15 20:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-14  9:06 [PATCH 1/2] doc: filesystems: proc: Remove stray '-' preventing table output Chris Packham
2020-07-14  9:06 ` [PATCH 2/2] doc: filesystems: proc: Fix literal blocks Chris Packham
2020-07-14  9:57   ` Mike Rapoport
2020-07-15 20:47   ` Chris Packham [this message]
2020-07-14  9:57 ` [PATCH 1/2] doc: filesystems: proc: Remove stray '-' preventing table output Mike Rapoport
2020-07-14 13:51 ` Jonathan Corbet
2020-07-15 20:44   ` Chris Packham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d80a1ae-ba46-1840-a4a4-4046413d1c1c@alliedtelesis.co.nz \
    --to=chris.packham@alliedtelesis.co.nz \
    --cc=adobriyan@gmail.com \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    --subject='Re: [PATCH 2/2] doc: filesystems: proc: Fix literal blocks' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).