linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: adam.manzanares@wdc.com, viro@zeniv.linux.org.uk,
	linux-fsdevel@vger.kernel.org, bcrl@kvack.org
Cc: mingo@kernel.org, peterz@infradead.org, pombredanne@nexb.com,
	gregkh@linuxfoundation.org, bigeasy@linutronix.de,
	rgoldwyn@suse.com, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-aio@kvack.org,
	linux-api@vger.kernel.org
Subject: Re: [PATCH v4 0/3] AIO add per-command iopriority
Date: Thu, 17 May 2018 20:41:32 -0600	[thread overview]
Message-ID: <3ec960cf-e14c-6ff6-3356-186136f43df7@kernel.dk> (raw)
In-Reply-To: <20180517203803.2664-1-adam.manzanares@wdc.com>

On 5/17/18 2:38 PM, adam.manzanares@wdc.com wrote:
> From: Adam Manzanares <adam.manzanares@wdc.com>
> 
> This is the per-I/O equivalent of the ioprio_set system call.
> See the following link for performance implications on a SATA HDD:
> https://lkml.org/lkml/2016/12/6/495
> 
> First patch factors ioprio_check_cap function out of ioprio_set system call to
> also be used by the aio ioprio interface.
> 
> Second patch converts kiocb ki_hint field to a u16 to avoid kiocb bloat.
> 
> Third patch passes ioprio hint from aio iocb to kiocb and enables block_dev
> usage of the per I/O ioprio feature.
> 
> v2: merge patches
>     use IOCB_FLAG_IOPRIO
>     validate intended use with IOCB_IOPRIO
>     add linux-api and linux-block to cc
> 
> v3: add ioprio_check_cap function
>     convert kiocb ki_hint to u16
>     use ioprio_check_cap when adding ioprio to kiocb in aio.c
> 
> v4: handle IOCB_IOPRIO in aio_prep_rw
>     note patch 3 depends on patch 1 in commit msg
> 
> Adam Manzanares (3):
>   block: add ioprio_check_cap function
>   fs: Convert kiocb rw_hint from enum to u16
>   fs: Add aio iopriority support for block_dev
> 
>  block/ioprio.c               | 22 ++++++++++++++++------
>  fs/aio.c                     | 16 ++++++++++++++++
>  fs/block_dev.c               |  2 ++
>  include/linux/fs.h           | 17 +++++++++++++++--
>  include/linux/ioprio.h       |  2 ++
>  include/uapi/linux/aio_abi.h |  1 +
>  6 files changed, 52 insertions(+), 8 deletions(-)

This looks fine to me now. I can pick up #1 for 4.18 - and 2+3 as well,
unless someone else wants to take them.

-- 
Jens Axboe

  parent reply	other threads:[~2018-05-18  2:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17 20:38 [PATCH v4 0/3] AIO add per-command iopriority adam.manzanares
2018-05-17 20:38 ` [PATCH v4 1/3] block: add ioprio_check_cap function adam.manzanares
2018-05-18 16:04   ` Christoph Hellwig
2018-05-17 20:38 ` [PATCH v4 2/3] fs: Convert kiocb rw_hint from enum to u16 adam.manzanares
2018-05-18 16:05   ` Christoph Hellwig
2018-05-18 19:53     ` Adam Manzanares
2018-05-17 20:38 ` [PATCH v4 3/3] fs: Add aio iopriority support for block_dev adam.manzanares
2018-05-18 15:14   ` Jens Axboe
2018-05-18 15:29     ` Adam Manzanares
2018-05-18 16:06   ` Christoph Hellwig
2018-05-18 19:54     ` Adam Manzanares
2018-05-18 20:08   ` kbuild test robot
2018-05-18  2:41 ` Jens Axboe [this message]
2018-05-18 15:03   ` [PATCH v4 0/3] AIO add per-command iopriority Adam Manzanares

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ec960cf-e14c-6ff6-3356-186136f43df7@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=adam.manzanares@wdc.com \
    --cc=bcrl@kvack.org \
    --cc=bigeasy@linutronix.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-aio@kvack.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=pombredanne@nexb.com \
    --cc=rgoldwyn@suse.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).