From: Josef Bacik <josef@toxicpanda.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: hch@lst.de, viro@zeniv.linux.org.uk,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH] proc: use vmalloc for our kernel buffer
Date: Thu, 13 Aug 2020 11:08:41 -0400 [thread overview]
Message-ID: <3fad71b2-eda1-aca4-f421-41d2097e4769@toxicpanda.com> (raw)
In-Reply-To: <20200813145941.GJ17456@casper.infradead.org>
On 8/13/20 10:59 AM, Matthew Wilcox wrote:
> On Thu, Aug 13, 2020 at 10:53:05AM -0400, Josef Bacik wrote:
>> +/**
>> + * vmemdup_user - duplicate memory region from user space and NUL-terminate
>
> vmemdup_user_nul()
>
>> +void *vmemdup_user_nul(const void __user *src, size_t len)
>> +{
>> + void *p;
>> +
>> + p = kvmalloc(len, GFP_USER);
>
> len+1, shirley?
>
>> + if (!p)
>> + return ERR_PTR(-ENOMEM);
>> +
>> + if (copy_from_user(p, src, len)) {
>> + kvfree(p);
>> + return ERR_PTR(-EFAULT);
>> + }
>
> I think you forgot
>
> p[len] = '\0';
>
Sweet lord I need more sleep, my bad. Thanks,
Josef
next prev parent reply other threads:[~2020-08-13 15:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 14:53 [PATCH] proc: use vmalloc for our kernel buffer Josef Bacik
2020-08-13 14:59 ` Matthew Wilcox
2020-08-13 15:08 ` Josef Bacik [this message]
2020-08-13 15:33 ` [PATCH][v2] " Josef Bacik
2020-08-13 15:37 ` Christoph Hellwig
2020-08-13 15:40 ` Josef Bacik
2020-08-13 15:41 ` Christoph Hellwig
2020-08-13 16:20 ` Al Viro
2020-08-13 17:19 ` Josef Bacik
2020-08-13 17:31 ` Al Viro
2020-08-13 17:36 ` Josef Bacik
2020-08-13 21:10 ` David Laight
2020-08-13 21:31 ` Josef Bacik
2020-08-13 16:19 ` [PATCH] " David Laight
2020-08-13 16:21 ` Al Viro
2020-08-13 17:08 ` Josef Bacik
2021-02-10 15:54 Josef Bacik
2021-02-10 17:16 ` Vlastimil Babka
2021-02-10 18:15 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fad71b2-eda1-aca4-f421-41d2097e4769@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=hch@lst.de \
--cc=kernel-team@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).