From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C87CC169C4 for ; Wed, 6 Feb 2019 15:05:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D32572175B for ; Wed, 6 Feb 2019 15:05:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="tKvdshet" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730122AbfBFPFH (ORCPT ); Wed, 6 Feb 2019 10:05:07 -0500 Received: from mail-it1-f194.google.com ([209.85.166.194]:54377 "EHLO mail-it1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726767AbfBFPFG (ORCPT ); Wed, 6 Feb 2019 10:05:06 -0500 Received: by mail-it1-f194.google.com with SMTP id i145so6919190ita.4 for ; Wed, 06 Feb 2019 07:05:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MaWMDvRvZTyH54ESO6gsvuugTV7kMm5WOysIWfGTjjE=; b=tKvdshetyQeFs7guNK44myWD8le8qYqbTKiD/HKtjw/SJjW/GT1C4knUe/CQmtmsP1 ktzd889YEvrL6EyoqeDkx2HJzVe/EeTSV0AFxExmvfa4AKzjf5vWPK0+s3/SOQVsuEs4 chixXtU7U/D1wlhGbeGYoF7+qStgyvzYmzxw0Fo42wNhne1EIUeQf/FLDH9jAX1PzNiD AxkIbihIR6smlnhUhpws+iBK2qVsgwTEcyiB498Uk/dcmatxsEb90WcHvOAH6fa0cMKt EoH1O0GKTWGAUCXKqOQCxBbhqZeUJShedQ+KwGYLGBEdIuf4wMI0L1su9sxLwzH6XxPW oC5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MaWMDvRvZTyH54ESO6gsvuugTV7kMm5WOysIWfGTjjE=; b=PhPkSEKQ5Drn9rF7I1szS8w1AX6sDk1GBIYsiF2O8w1hdf5vZiO3tWSChUweTjG7qs wUES41aEnou1kn2cOa9Hd0A1biEb25BXtU9trbXhNkfINuTfzsonpCsyfmuE/CbRcyjI 9JvBlqXvMcBaPDebRV8gkQeXGX0qGyBR0WH9d7QfGopF0+L19gBd0X3aPHwmN4ZaZ9aE +f1pjp6A3sh6PKVQNLeQe90RUYV1/PBd6NmKu9dZPC+7ANT96Bn8Oah3taKAIOflF4Hd FV6ei3UicbcTPiHZhtNOVC8vSnfDPSebXKxOEgR1knZLfd6QzN8XhxIjXo2ZmKoG80Hv UvJw== X-Gm-Message-State: AHQUAuZMycaTsVaK5coNmp9XstOyE1Y/A3kG8uKuUWU4ZTZqJX7IBJbh CMKW+On4BEmQnCv+CbZNpsl/Wg== X-Google-Smtp-Source: AHgI3IbLGoFf8RjYkDqUsvkgTbftPDm/54PHesweCXDmtsJVeg6vHYdLQS47HAwDvO3E0bp8osbodw== X-Received: by 2002:a02:a15e:: with SMTP id m30mr5878183jah.143.1549465505539; Wed, 06 Feb 2019 07:05:05 -0800 (PST) Received: from [192.168.1.158] ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id s10sm3264830iob.7.2019.02.06.07.05.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Feb 2019 07:05:03 -0800 (PST) Subject: Re: [PATCH 0/2] aio: intialize kiocb private To: hubcap@kernel.org, linux-fsdevel@vger.kernel.org Cc: Mike Marshall , viro@zeniv.linux.org.uk, hch@lst.de, martin@omnibond.com References: <20190205191335.22056-1-hubcap@kernel.org> From: Jens Axboe Message-ID: <41f75d4e-fddd-3397-2b5b-fe47a9c694a4@kernel.dk> Date: Wed, 6 Feb 2019 08:05:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190205191335.22056-1-hubcap@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 2/5/19 12:13 PM, hubcap@kernel.org wrote: > From: Mike Marshall > > "aio: don't zero entire aio_kiocb aio_get_req" triggered these > BUG_ONs in orangefs file.c. Obviously the BUG_ONs need to go. > > There might be other filesystems that use iocb->private without > failing in a way that is as obvious as BUG_ON, though I didn't > see any with grep. > > After discussion on fsdevel, Jens Axboe suggested I should send > in a patch that continues to set iocb->private to NULL just in case. > > Also... phooey on fighting gmail when trying to send patches with > git-send-email... mail.kernel.org works great! Applied 1/2, 2/2 should probably just go in separately with other orangefs patches, when appropriate. -- Jens Axboe