From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f175.google.com ([209.85.216.175]:36616 "EHLO mail-qt0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770AbdAQEur (ORCPT ); Mon, 16 Jan 2017 23:50:47 -0500 Received: by mail-qt0-f175.google.com with SMTP id k15so137468094qtg.3 for ; Mon, 16 Jan 2017 20:50:47 -0800 (PST) Subject: Re: utimensat EACCES vs. EPERM in 4.8+ To: mtk.manpages@gmail.com, Miklos Szeredi References: <18a5b416-ad6a-e679-d993-af7ffa0dcc10@redhat.com> Cc: Jan Stancek , linux-fsdevel , viro , guaneryu@gmail.com, Cyril Hrubis , ltp@lists.linux.it, Linux API , Dave Chinner From: Carlos O'Donell Message-ID: <432649da-a5d6-e448-e72e-76b68db16bb9@redhat.com> Date: Mon, 16 Jan 2017 23:50:43 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 01/16/2017 07:04 PM, Michael Kerrisk (man-pages) wrote: > [CC += linux-api + Dave Chinner] > Summary of the above list: there's a nontrivial risk that something in > userspace got broken. (And just because we didn't hear about it yet > doesn't mean it didn't happen; sometimes these reports only arrive > many months or even years later.) > > So, (1) I'm struggling to see the rationale for this change (I don't > think "consistency" is enough) and (2) if "consistency" is the > argument then (because the set of system calls in [1] are more > frequently used than those in [2]), there's a reasonable argument that > the change should have gone the other way: changing all IS_IMMUTABLE > cases to fail with EACCES. > > Summary: I think there's an argument for reverting the kernel patch. Completely agree. Even if you go ahead with these changes, they really should go through some kind of distro verification [1]. If I even contemplated such a change in glibc I'd run it through 4-6 months of Fedora Rawhide builds just to see what breaks before putting it out in a real release (and we do this frequently for thread-related changes). -- Cheers, Carlos. [1] "Usage of Fedora Rawhide" https://fedoraproject.org/wiki/Glibc