From: Waiman Long <longman@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Dan Williams <dan.j.williams@gmail.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, Stephen Rothwell <sfr@canb.auug.org.au>,
"Michael S. Tsirkin" <mst@redhat.com>,
Toshiki Fukasawa <t-fukasawa@vx.jp.nec.com>
Subject: Re: [PATCH v2] fs/proc/page: Skip uninitialized page when iterating page structures
Date: Wed, 28 Aug 2019 10:18:41 -0400 [thread overview]
Message-ID: <4367f507-97ba-a74e-6bf5-811cdd6ecdf9@redhat.com> (raw)
In-Reply-To: <20190828140938.GL28313@dhcp22.suse.cz>
On 8/28/19 10:09 AM, Michal Hocko wrote:
> On Wed 28-08-19 09:46:21, Waiman Long wrote:
>> On 8/28/19 4:00 AM, Michal Hocko wrote:
>>> On Tue 27-08-19 16:22:38, Michal Hocko wrote:
>>>> Dan, isn't this something we have discussed recently?
>>> This was http://lkml.kernel.org/r/20190725023100.31141-3-t-fukasawa@vx.jp.nec.com
>>> and talked about /proc/kpageflags but this is essentially the same thing
>>> AFAIU. I hope we get a consistent solution for both issues.
>>>
>> Yes, it is the same problem. The uninitialized page structure problem
>> affects all the 3 /proc/kpage{cgroup,count,flags) files.
>>
>> Toshiki's patch seems to fix it just for /proc/kpageflags, though.
> Yup. I was arguing that whacking a mole kinda fix is far from good. Dan
> had some arguments on why initializing those struct pages is a problem.
> The discussion had a half open end though. I hoped that Dan would try
> out the initialization side but I migh have misunderstood.
If the page structures of the reserved PFNs are always initialized, that
will fix the problem too. I am not familiar with the zone device code.
So I didn't attempt to do that.
Cheers,
Longman
next prev parent reply other threads:[~2019-08-28 14:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 12:43 [PATCH v2] fs/proc/page: Skip uninitialized page when iterating page structures Waiman Long
2019-08-26 13:25 ` Matthew Wilcox
2019-08-26 13:43 ` Waiman Long
2019-08-26 13:49 ` Waiman Long
2019-08-26 14:20 ` Matthew Wilcox
2019-08-27 14:22 ` Michal Hocko
2019-08-28 8:00 ` Michal Hocko
2019-08-28 13:46 ` Waiman Long
2019-08-28 14:09 ` Michal Hocko
2019-08-28 14:18 ` Waiman Long [this message]
2019-08-29 1:47 ` Toshiki Fukasawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4367f507-97ba-a74e-6bf5-811cdd6ecdf9@redhat.com \
--to=longman@redhat.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mst@redhat.com \
--cc=sfr@canb.auug.org.au \
--cc=t-fukasawa@vx.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).