From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66BC8C3A5A4 for ; Fri, 23 Aug 2019 17:05:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3EDBF233FD for ; Fri, 23 Aug 2019 17:05:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566579944; bh=nxBLgk8vy88bDQ4Gy8gLYJzufdYGTQ7XtUM6JqEXDA0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=y9fXMGlWbqCOv355qZwwLh8VEiZsbbyjDwS7Wjug71/+5rNHGSgVHL9/obPxfGuk+ 7Bsp55N9XJPNzAIUXvx9J9dKcnX62ba9HcB5mGmCCCH4doPXQEbZRfSE2PYcDj10O9 No0ZJvvDiwdBIOWCjoQFTaomzHyp0ZauK3dpU5dQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728263AbfHWRFk (ORCPT ); Fri, 23 Aug 2019 13:05:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:56434 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727388AbfHWRFk (ORCPT ); Fri, 23 Aug 2019 13:05:40 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2AE5222CE3; Fri, 23 Aug 2019 17:05:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566579938; bh=nxBLgk8vy88bDQ4Gy8gLYJzufdYGTQ7XtUM6JqEXDA0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=O30aLpnr4wR6RV3N8mtzuIwqjR4pVRciIGqcKMKqRxgQeexe3DQTFu7wLf0ucs6pd f7LERWiM15wbjLXop4rZCGtrGB+P5H5sTrfEx/6zUqN9gIAyJVuBsS52i6gSBIEa3N Okrm+v4nJmDbL6aK4SO4xEICK/zDQDTaPoFPQAwI= Subject: Re: [PATCH v14 01/18] kunit: test: add KUnit test runner core To: Brendan Higgins Cc: Frank Rowand , Greg KH , Josh Poimboeuf , Kees Cook , Kieran Bingham , Luis Chamberlain , Peter Zijlstra , Rob Herring , Stephen Boyd , Theodore Ts'o , Masahiro Yamada , devicetree , dri-devel , kunit-dev@googlegroups.com, "open list:DOCUMENTATION" , linux-fsdevel@vger.kernel.org, linux-kbuild , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , linux-nvdimm , linux-um@lists.infradead.org, Sasha Levin , "Bird, Timothy" , Amir Goldstein , Dan Carpenter , Daniel Vetter , Jeff Dike , Joel Stanley , Julia Lawall , Kevin Hilman , Knut Omang , Logan Gunthorpe , Petr Mladek , Randy Dunlap , Richard Weinberger , David Rientjes , Steven Rostedt , wfg@linux.intel.com, shuah References: <20190820232046.50175-1-brendanhiggins@google.com> <20190820232046.50175-2-brendanhiggins@google.com> <7f2c8908-75f6-b793-7113-ad57c51777ce@kernel.org> From: shuah Message-ID: <4513d9f3-a69b-a9a4-768b-86c2962b62e0@kernel.org> Date: Fri, 23 Aug 2019 11:05:35 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 8/23/19 10:48 AM, Brendan Higgins wrote: > On Fri, Aug 23, 2019 at 8:33 AM shuah wrote: >> >> Hi Brendan, >> >> On 8/20/19 5:20 PM, Brendan Higgins wrote: >>> Add core facilities for defining unit tests; this provides a common way >>> to define test cases, functions that execute code which is under test >>> and determine whether the code under test behaves as expected; this also >>> provides a way to group together related test cases in test suites (here >>> we call them test_modules). >>> >>> Just define test cases and how to execute them for now; setting >>> expectations on code will be defined later. >>> >>> Signed-off-by: Brendan Higgins >>> Reviewed-by: Greg Kroah-Hartman >>> Reviewed-by: Logan Gunthorpe >>> Reviewed-by: Luis Chamberlain >>> Reviewed-by: Stephen Boyd >>> --- >>> include/kunit/test.h | 179 ++++++++++++++++++++++++++++++++++++++++ >>> kunit/Kconfig | 17 ++++ >>> kunit/Makefile | 1 + >>> kunit/test.c | 191 +++++++++++++++++++++++++++++++++++++++++++ >>> 4 files changed, 388 insertions(+) >>> create mode 100644 include/kunit/test.h >>> create mode 100644 kunit/Kconfig >>> create mode 100644 kunit/Makefile >>> create mode 100644 kunit/test.c >>> >>> diff --git a/include/kunit/test.h b/include/kunit/test.h >>> new file mode 100644 >>> index 0000000000000..e0b34acb9ee4e >>> --- /dev/null >>> +++ b/include/kunit/test.h >>> @@ -0,0 +1,179 @@ >>> +/* SPDX-License-Identifier: GPL-2.0 */ >>> +/* >>> + * Base unit test (KUnit) API. >>> + * >>> + * Copyright (C) 2019, Google LLC. >>> + * Author: Brendan Higgins >>> + */ >>> + >>> +#ifndef _KUNIT_TEST_H >>> +#define _KUNIT_TEST_H >>> + >>> +#include >>> + >>> +struct kunit; >>> + >>> +/** >>> + * struct kunit_case - represents an individual test case. >>> + * @run_case: the function representing the actual test case. >>> + * @name: the name of the test case. >>> + * >>> + * A test case is a function with the signature, ``void (*)(struct kunit *)`` >>> + * that makes expectations (see KUNIT_EXPECT_TRUE()) about code under test. Each >>> + * test case is associated with a &struct kunit_suite and will be run after the >>> + * suite's init function and followed by the suite's exit function. >>> + * >>> + * A test case should be static and should only be created with the KUNIT_CASE() >>> + * macro; additionally, every array of test cases should be terminated with an >>> + * empty test case. >>> + * >>> + * Example: >> >> Can you fix these line continuations. It makes it very hard to read. >> Sorry for this late comment. These comments lines are longer than 80 >> and wrap. > > None of the lines in this commit are over 80 characters in column > width. Some are exactly 80 characters (like above). > > My guess is that you are seeing the diff added text (+ ), which when > you add that to a line which is exactly 80 char in length ends up > being over 80 char in email. If you apply the patch you will see that > they are only 80 chars. > >> >> There are several comment lines in the file that are way too long. > > Note that checkpatch also does not complain about any over 80 char > lines in this file. > > Sorry if I am misunderstanding what you are trying to tell me. Please > confirm either way. > WARNING: Avoid unnecessary line continuations #258: FILE: include/kunit/test.h:137: + */ \ total: 0 errors, 2 warnings, 388 lines checked Go ahead fix these. It appears there are few lines that either longer than 80. In general, I keep them around 75, so it is easier read. thanks, -- Shuah