From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.alarsen.net ([144.76.18.233]:46236 "EHLO mail.alarsen.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751998AbeENKz2 (ORCPT ); Mon, 14 May 2018 06:55:28 -0400 From: Anders Larsen To: Al Viro Cc: linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 07/15] qnx4_lookup: use d_splice_alias() Date: Mon, 14 May 2018 12:48:59 +0200 Message-ID: <4514241.SzgC0XFIME@alarsen-lx> In-Reply-To: <20180513213017.31269-7-viro@ZenIV.linux.org.uk> References: <20180513212612.GV30522@ZenIV.linux.org.uk> <20180513213017.31269-1-viro@ZenIV.linux.org.uk> <20180513213017.31269-7-viro@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sunday, 13 May 2018 22:30 Al Viro wrote: > From: Al Viro > > Cc: Anders Larsen > Signed-off-by: Al Viro > --- > fs/qnx4/namei.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) Acked-by: Anders Larsen > diff --git a/fs/qnx4/namei.c b/fs/qnx4/namei.c > index eca27878079d..8d72221735d7 100644 > --- a/fs/qnx4/namei.c > +++ b/fs/qnx4/namei.c > @@ -114,13 +114,9 @@ struct dentry * qnx4_lookup(struct inode *dir, struct > dentry *dentry, unsigned i brelse(bh); > > foundinode = qnx4_iget(dir->i_sb, ino); > - if (IS_ERR(foundinode)) { > + if (IS_ERR(foundinode)) > QNX4DEBUG((KERN_ERR "qnx4: lookup->iget -> error %ld\n", > PTR_ERR(foundinode))); > - return ERR_CAST(foundinode); > - } > out: > - d_add(dentry, foundinode); > - > - return NULL; > + return d_splice_alias(foundinode, dentry); > }