From: Randy Dunlap <rdunlap@infradead.org>
To: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, kernel-team@fb.com,
akpm@linux-foundation.org, hannes@cmpxchg.org,
linux-kernel@vger.kernel.org, tj@kernel.org,
linux-fsdevel@vger.kernel.org
Cc: Josef Bacik <jbacik@fb.com>
Subject: Re: [PATCH 12/15] block: introduce blk-iolatency io controller
Date: Wed, 27 Jun 2018 16:53:22 -0700 [thread overview]
Message-ID: <46234c71-9e27-b2f5-63cf-c9727117af82@infradead.org> (raw)
In-Reply-To: <8a8c7008-b64d-1cf0-4cad-bdb73d37b53e@kernel.dk>
On 06/27/2018 12:06 PM, Jens Axboe wrote:
> From: Josef Bacik <jbacik@fb.com>
>
> Signed-off-by: Josef Bacik <jbacik@fb.com>
Hi,
> ---
> block/Kconfig | 12 +
> block/Makefile | 1 +
> block/blk-iolatency.c | 903 ++++++++++++++++++++++++++++++++++++++++++++++
> block/blk-sysfs.c | 2 +
> block/blk.h | 6 +
> include/linux/blk_types.h | 2 -
> 6 files changed, 924 insertions(+), 2 deletions(-)
> create mode 100644 block/blk-iolatency.c
>
> diff --git a/block/Kconfig b/block/Kconfig
> index 28ec55752b68..c3205b2003a0 100644
> --- a/block/Kconfig
> +++ b/block/Kconfig
> @@ -149,6 +149,18 @@ config BLK_WBT
> dynamically on an algorithm loosely based on CoDel, factoring in
> the realtime performance of the disk.
>
> +config BLK_CGROUP_IOLATENCY
> + bool "Enable support for latency based cgroup IO protection"
> + depends on BLK_CGROUP=y
> + default n
> + ---help---
> + Enabling this option enables the .latency interface for IO throttling.
> + The IO controller will attempt to maintain average io latencies below
IO
please.
> + the configured latency target, throttling anybody with a higher latency
> + target than the victimized group.
> +
> + Note, this is an experimental interface and could be changed someday.
> +
> config BLK_WBT_SQ
> bool "Single queue writeback throttling"
> default n
--
~Randy
prev parent reply other threads:[~2018-06-27 23:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 15:12 [PATCH 0/15][V3] Introduce io.latency io controller for cgroups Josef Bacik
2018-06-25 15:12 ` [PATCH 01/15] block: add bi_blkg to the bio " Josef Bacik
2018-06-25 15:12 ` [PATCH 02/15] block: introduce bio_issue_as_root_blkg Josef Bacik
2018-06-25 15:12 ` [PATCH 03/15] blk-cgroup: allow controllers to output their own stats Josef Bacik
2018-06-25 15:12 ` [PATCH 04/15] blk: introduce REQ_SWAP Josef Bacik
2018-06-25 15:12 ` [PATCH 05/15] swap,blkcg: issue swap io with the appropriate context Josef Bacik
2018-06-25 15:12 ` [PATCH 06/15] blkcg: add generic throttling mechanism Josef Bacik
2018-06-25 15:12 ` [PATCH 07/15] memcontrol: schedule throttling if we are congested Josef Bacik
2018-06-25 15:12 ` [PATCH 08/15] blk-stat: export helpers for modifying blk_rq_stat Josef Bacik
2018-06-25 15:12 ` [PATCH 09/15] blk-rq-qos: refactor out common elements of blk-wbt Josef Bacik
2018-06-25 15:12 ` [PATCH 10/15] block: remove external dependency on wbt_flags Josef Bacik
2018-06-25 15:12 ` [PATCH 11/15] rq-qos: introduce dio_bio callback Josef Bacik
2018-06-25 15:12 ` [PATCH 12/15] block: introduce blk-iolatency io controller Josef Bacik
2018-06-27 19:06 ` Jens Axboe
2018-06-27 19:20 ` Josef Bacik
2018-06-27 19:24 ` Jens Axboe
2018-06-28 13:26 ` Josef Bacik
2018-06-28 15:35 ` Jens Axboe
2018-06-25 15:12 ` [PATCH 13/15] Documentation: add a doc for blk-iolatency Josef Bacik
2018-06-25 22:36 ` Randy Dunlap
2018-06-25 15:12 ` [PATCH 14/15] skip readahead if the cgroup is congested Josef Bacik
2018-06-25 15:12 ` [PATCH 15/15] block: use irq variant for blkcg->lock Josef Bacik
2018-06-27 19:06 ` [PATCH 12/15] block: introduce blk-iolatency io controller Jens Axboe
2018-06-27 23:53 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46234c71-9e27-b2f5-63cf-c9727117af82@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=hannes@cmpxchg.org \
--cc=jbacik@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).