From: Pankaj Gupta <pagupta@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-acpi@vger.kernel.org,
qemu-devel@nongnu.org, linux-ext4@vger.kernel.org,
linux-xfs@vger.kernel.org,
dan j williams <dan.j.williams@intel.com>,
zwisler@kernel.org, vishal l verma <vishal.l.verma@intel.com>,
dave jiang <dave.jiang@intel.com>,
mst@redhat.com, jasowang@redhat.com, willy@infradead.org,
rjw@rjwysocki.net, hch@infradead.org, lenb@kernel.org,
jack@suse.cz, tytso@mit.edu,
adilger kernel <adilger.kernel@dilger.ca>,
darrick wong <darrick.wong@oracle.com>,
lcapitulino@redhat.com, kwolf@redhat.com, imammedo@redhat.com,
jmoyer@redhat.com, nilal@redhat.com, riel@surriel.com,
stefanha@redhat.com, aarcange@redhat.com, david@redhat.com,
cohuck@redhat.com,
xiaoguangrong eric <xiaoguangrong.eric@gmail.com>,
pbonzini@redhat.com, yuval shaia <yuval.shaia@oracle.com>,
kilobyte@angband.pl
Subject: Re: [PATCH v6 6/6] xfs: disable map_sync for async flush
Date: Wed, 24 Apr 2019 00:55:40 -0400 (EDT) [thread overview]
Message-ID: <476344290.23160847.1556081740211.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20190423220217.GA29573@dread.disaster.area>
>
> On Tue, Apr 23, 2019 at 01:36:12PM +0530, Pankaj Gupta wrote:
> > Dont support 'MAP_SYNC' with non-DAX files and DAX files
> > with asynchronous dax_device. Virtio pmem provides
> > asynchronous host page cache flush mechanism. We don't
> > support 'MAP_SYNC' with virtio pmem and xfs.
> >
> > Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
> > ---
> > fs/xfs/xfs_file.c | 10 ++++++----
> > 1 file changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
> > index 1f2e2845eb76..0e59be018511 100644
> > --- a/fs/xfs/xfs_file.c
> > +++ b/fs/xfs/xfs_file.c
> > @@ -1196,11 +1196,13 @@ xfs_file_mmap(
> > struct file *filp,
> > struct vm_area_struct *vma)
> > {
> > - /*
> > - * We don't support synchronous mappings for non-DAX files. At least
> > - * until someone comes with a sensible use case.
> > + struct dax_device *dax_dev = xfs_find_daxdev_for_inode
> > + (file_inode(filp));
> > +
> > + /* We don't support synchronous mappings for non-DAX files and
> > + * for DAX files if underneath dax_device is not synchronous.
> > */
>
> /*
> * This is the correct multi-line comment format. Please
> * update the patch to maintain the existing comment format.
> */
Sure. Will correct this for both xfs & ext4.
Thanks,
Pankaj
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
>
prev parent reply other threads:[~2019-04-24 4:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 8:06 [PATCH v6 0/6] virtio pmem driver Pankaj Gupta
2019-04-23 8:06 ` [PATCH v6 1/6] libnvdimm: nd_region flush callback support Pankaj Gupta
2019-04-23 8:06 ` [PATCH v6 2/6] virtio-pmem: Add virtio pmem driver Pankaj Gupta
2019-04-23 8:06 ` [PATCH v6 3/6] libnvdimm: add dax_dev sync flag Pankaj Gupta
2019-04-23 8:06 ` [PATCH v6 4/6] dax: check synchronous mapping is supported Pankaj Gupta
2019-04-23 14:27 ` Jan Kara
2019-04-23 8:06 ` [PATCH v6 5/6] ext4: disable map_sync for async flush Pankaj Gupta
2019-04-23 14:27 ` Jan Kara
2019-04-24 5:21 ` [Qemu-devel] " Pankaj Gupta
2019-04-23 8:06 ` [PATCH v6 6/6] xfs: " Pankaj Gupta
2019-04-23 22:02 ` Dave Chinner
2019-04-23 22:10 ` Darrick J. Wong
2019-04-24 5:10 ` [Qemu-devel] " Pankaj Gupta
2019-04-24 4:55 ` Pankaj Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=476344290.23160847.1556081740211.JavaMail.zimbra@redhat.com \
--to=pagupta@redhat.com \
--cc=aarcange@redhat.com \
--cc=adilger.kernel@dilger.ca \
--cc=cohuck@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=darrick.wong@oracle.com \
--cc=dave.jiang@intel.com \
--cc=david@fromorbit.com \
--cc=david@redhat.com \
--cc=hch@infradead.org \
--cc=imammedo@redhat.com \
--cc=jack@suse.cz \
--cc=jasowang@redhat.com \
--cc=jmoyer@redhat.com \
--cc=kilobyte@angband.pl \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mst@redhat.com \
--cc=nilal@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riel@surriel.com \
--cc=rjw@rjwysocki.net \
--cc=stefanha@redhat.com \
--cc=tytso@mit.edu \
--cc=virtualization@lists.linux-foundation.org \
--cc=vishal.l.verma@intel.com \
--cc=willy@infradead.org \
--cc=xiaoguangrong.eric@gmail.com \
--cc=yuval.shaia@oracle.com \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).