From: Johannes Thumshirn <jthumshirn@suse.de>
To: Hannes Reinecke <hare@suse.de>, Jens Axboe <axboe@fb.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
Christoph Hellwig <hch@lst.de>, Jan Kara <jack@suse.cz>,
Linux Block Layer Mailinglist <linux-block@vger.kernel.org>,
Linux FSDEVEL Mailinglist <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 1/2] block: bio: ensure newly added bio flags don't override BVEC_POOL_IDX
Date: Thu, 21 Mar 2019 14:22:25 +0100 [thread overview]
Message-ID: <4771867f-1cfe-67f6-10de-27c278fe9c3c@suse.de> (raw)
In-Reply-To: <886489c7-133d-b0bb-6ae9-f054727985e4@suse.de>
On 21/03/2019 14:18, Hannes Reinecke wrote:
> Where's the point of the enum if all values are initialized?
Enums start at 0 if not otherwise initialized and I wanted to keep the
unused 0th bit as unused in this patch, for either the patch from Jens
or 2/2 in this series.
It's the only reason and it is not wrong to do and not the only place
where we have it:
jthumshirn@glass:linux (master)$ git grep -A 1 "enum {" | grep "= 0" | wc -l
2206
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2019-03-21 13:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 12:30 [PATCH 0/2] add flag for tracking bio allocation Johannes Thumshirn
2019-03-21 12:30 ` [PATCH 1/2] block: bio: ensure newly added bio flags don't override BVEC_POOL_IDX Johannes Thumshirn
2019-03-21 13:18 ` Hannes Reinecke
2019-03-21 13:22 ` Johannes Thumshirn [this message]
2019-03-21 14:15 ` Jens Axboe
2019-03-21 14:21 ` Jens Axboe
2019-03-21 14:23 ` Johannes Thumshirn
2019-03-21 14:25 ` Jens Axboe
2019-03-21 15:54 ` Hannes Reinecke
2019-03-22 10:24 ` Johannes Thumshirn
2019-03-21 12:30 ` [PATCH 2/2] bio: introduce BIO_ALLOCED flag and check it in bio_free Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4771867f-1cfe-67f6-10de-27c278fe9c3c@suse.de \
--to=jthumshirn@suse.de \
--cc=axboe@fb.com \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).