From: "Benjamin Coddington" <bcodding@redhat.com>
To: "Alexander Viro" <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] mnt: fix __detach_mounts infinite loop
Date: Mon, 22 Oct 2018 10:14:53 -0400 [thread overview]
Message-ID: <477E0417-EF75-4A2D-AB3E-0C5E6B8E1D67@redhat.com> (raw)
In-Reply-To: <9d2d5b14bac03eb3cd9d6daa476a294e83a69ab6.1538576163.git.bcodding@redhat.com>
Al, would you be willing to take a look at this one?
Ben
On 3 Oct 2018, at 10:18, Benjamin Coddington wrote:
> v2: less whitespace
>
> 8<------------------------------------------------------------------------
>
> Since commit ff17fa561a04 ("d_invalidate(): unhash immediately")
> immediately unhashes the dentry, we'll never return the mountpoint in
> lookup_mountpoint(), which can lead to an unbreakable loop in
> d_invalidate().
>
> I have reports of NFS clients getting into this condition after the
> server
> removes an export of an existing mount created through
> follow_automount(),
> but I suspect there are various other ways to produce this problem if
> we
> hunt down users of d_invalidate(). For example, it is possible to get
> into
> this state by using XFS' d_invalidate() call in xfs_vn_unlink():
>
> truncate -s 100m img{1,2}
>
> mkfs.xfs -q -n version=ci img1
> mkfs.xfs -q -n version=ci img2
>
> mkdir -p /mnt/xfs
> mount img1 /mnt/xfs
>
> mkdir /mnt/xfs/sub1
> mount img2 /mnt/xfs/sub1
>
> cat > /mnt/xfs/sub1/foo &
> umount -l /mnt/xfs/sub1
> mount img2 /mnt/xfs/sub1
>
> mount --make-private /mnt/xfs
>
> mkdir /mnt/xfs/sub2
> mount --move /mnt/xfs/sub1 /mnt/xfs/sub2
> rmdir /mnt/xfs/sub1
>
> Fix this by moving the check for an unlinked dentry out of the
> detach_mounts() path.
>
> Fixes: ff17fa561a04 ("d_invalidate(): unhash immediately")
> Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
> ---
> fs/namespace.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/namespace.c b/fs/namespace.c
> index bd2f4c68506a..ad8feb9371f2 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -780,9 +780,6 @@ static struct mountpoint *lookup_mountpoint(struct
> dentry *dentry)
>
> hlist_for_each_entry(mp, chain, m_hash) {
> if (mp->m_dentry == dentry) {
> - /* might be worth a WARN_ON() */
> - if (d_unlinked(dentry))
> - return ERR_PTR(-ENOENT);
> mp->m_count++;
> return mp;
> }
> @@ -796,6 +793,9 @@ static struct mountpoint *get_mountpoint(struct
> dentry *dentry)
> int ret;
>
> if (d_mountpoint(dentry)) {
> + /* might be worth a WARN_ON() */
> + if (d_unlinked(dentry))
> + return ERR_PTR(-ENOENT);
> mountpoint:
> read_seqlock_excl(&mount_lock);
> mp = lookup_mountpoint(dentry);
> --
> 2.14.3
next prev parent reply other threads:[~2018-10-22 22:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 14:10 [PATCH] mnt: fix __detach_mounts infinite loop Benjamin Coddington
2018-10-03 14:18 ` [PATCH v2] " Benjamin Coddington
2018-10-22 14:14 ` Benjamin Coddington [this message]
2018-10-25 23:31 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=477E0417-EF75-4A2D-AB3E-0C5E6B8E1D67@redhat.com \
--to=bcodding@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).