From: Yann Droneaud <ydroneaud@opteya.com>
To: Greg KH <greg@kroah.com>, David Howells <dhowells@redhat.com>
Cc: linux-api@vger.kernel.org, linux-kbuild@vger.kernel.org,
Michal Marek <michal.lkml@markovi.net>,
dri-devel@lists.freedesktop.org,
virtualization@lists.linux-foundation.org,
keyrings@vger.kernel.org, David Airlie <airlied@linux.ie>,
linux-nilfs@vger.kernel.org, linux-nvdimm@lists.01.org,
"Michael S. Tsirkin" <mst@redhat.com>,
codalist@coda.cs.cmu.edu, coda@cs.cmu.edu,
coreteam@netfilter.org, Rob Clark <robdclark@gmail.com>,
linux-arm-msm@vger.kernel.org,
Kent Overstreet <kent.overstreet@gmail.com>,
Dan Williams <dan.j.williams@intel.com>,
Takashi Iwai <tiwai@suse.com>,
linux-bcache@vger.kernel.org, Coly Li <colyli@suse.de>,
Jaroslav Kysela <perex@perex.cz>,
Jan Harkes <jaharkes@cs.cmu.edu>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>,
Jason Wang <jasowang@redhat.com>,
Mat Martineau <mathew.j.martineau@linux.intel.com>,
netfilter-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
moderated for non-subscribers <alsa-devel@alsa-project.org>,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] UAPI: Check headers by compiling all together as C++
Date: Thu, 06 Sep 2018 09:12:58 +0200 [thread overview]
Message-ID: <48b8af08170fb896c12cc4e3eae7501b4fa4181d.camel@opteya.com> (raw)
In-Reply-To: <a1efae8d26cc5b73b180e9521d6b62590c55aa86.camel@opteya.com>
Le mercredi 05 septembre 2018 à 19:33 +0200, Yann Droneaud a écrit :
> Le mercredi 05 septembre 2018 à 18:55 +0200, Greg KH a écrit :
> > On Wed, Sep 05, 2018 at 04:54:27PM +0100, David Howells wrote:
> > >
> > > Here's a set of patches that inserts a step into the build
> > > process to make
> > > sure that the UAPI headers can all be built together with C++ (if
> > > the
> > > compiler being used supports C++). All but the final patch
> > > perform fixups,
> > > including:
> >
> > Wait, why do we care? What has recently changed to start to
> > directly
> > import kernel uapi files into C++ code?
> >
> > And if userspace wants to do this, can't they do the C namespace
> > trick
> > themselves when they do the import? That must be how they are
> > doing it
> > today, right?
> >
>
> They can't.
>
>
> Adding extern "C" { } doesn't magically make "class" a non keyword.
> Even if it was the case, writing C++ code using whatever->class would
> probably broke because class is a keyword in C++.
>
For the record, libX11 has to handle the kink pf issue with C++
keyword:
https://gitlab.freedesktop.org/xorg/lib/libx11/blob/733f64bfeb311c1d040b2f751bfdef9c9d0f89ef/include/X11/Xlib.h#L227
typedef struct {
XExtData *ext_data; /* hook for extension to hang data */
VisualID visualid; /* visual id of this visual */
#if defined(__cplusplus) || defined(c_plusplus)
int c_class; /* C++ class of screen (monochrome, etc.) */
#else
int class; /* class of screen (monochrome, etc.) */
#endif
unsigned long red_mask, green_mask, blue_mask; /* mask values */
int bits_per_rgb; /* log base 2 of distinct color values */
int map_entries; /* color map entries */
} Visual;
Regards.
--
Yann Droneaud
OPTEYA
next prev parent reply other threads:[~2018-09-06 11:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 15:54 [RFC] UAPI: Check headers by compiling all together as C++ David Howells
2018-09-05 15:55 ` [PATCH 05/11] UAPI: coda: Don't use internal kernel structs in UAPI David Howells
2018-09-05 16:54 ` Jan Harkes
2018-09-05 17:12 ` Yann Droneaud
2018-09-05 17:28 ` Jan Harkes
2018-09-05 17:24 ` David Howells
2018-09-06 7:13 ` David Howells
2018-09-06 11:52 ` Yann Droneaud
2018-09-06 12:16 ` Jan Harkes
2018-09-06 14:53 ` David Howells
2018-09-05 15:55 ` [PATCH 07/11] UAPI: nilfs2: Fix use of undefined byteswapping functions David Howells
2018-09-05 22:20 ` Al Viro
2018-09-05 16:55 ` [RFC] UAPI: Check headers by compiling all together as C++ Greg KH
2018-09-05 17:33 ` Yann Droneaud
2018-09-05 17:42 ` Michael S. Tsirkin
2018-09-06 7:12 ` Yann Droneaud [this message]
2018-09-05 19:22 ` Jan Engelhardt
2018-09-05 17:50 ` David Howells
2018-09-06 9:18 David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48b8af08170fb896c12cc4e3eae7501b4fa4181d.camel@opteya.com \
--to=ydroneaud@opteya.com \
--cc=airlied@linux.ie \
--cc=alsa-devel@alsa-project.org \
--cc=coda@cs.cmu.edu \
--cc=codalist@coda.cs.cmu.edu \
--cc=colyli@suse.de \
--cc=coreteam@netfilter.org \
--cc=dan.j.williams@intel.com \
--cc=dhowells@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=greg@kroah.com \
--cc=jaharkes@cs.cmu.edu \
--cc=jasowang@redhat.com \
--cc=kent.overstreet@gmail.com \
--cc=keyrings@vger.kernel.org \
--cc=konishi.ryusuke@lab.ntt.co.jp \
--cc=linux-api@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=michal.lkml@markovi.net \
--cc=mst@redhat.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robdclark@gmail.com \
--cc=tiwai@suse.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).