From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 20/20] sysfs: Normalize error handling in sysfs_fill_inode Date: Thu, 21 May 2009 18:43:49 +0900 Message-ID: <4A152255.9060703@kernel.org> References: <1242865694-2100-5-git-send-email-ebiederm@xmission.com> <1242865694-2100-6-git-send-email-ebiederm@xmission.com> <1242865694-2100-7-git-send-email-ebiederm@xmission.com> <1242865694-2100-8-git-send-email-ebiederm@xmission.com> <1242865694-2100-9-git-send-email-ebiederm@xmission.com> <1242865694-2100-10-git-send-email-ebiederm@xmission.com> <1242865694-2100-11-git-send-email-ebiederm@xmission.com> <1242865694-2100-12-git-send-email-ebiederm@xmission.com> <1242865694-2100-13-git-send-email-ebiederm@xmission.com> <1242865694-2100-14-git-send-email-ebiederm@xmission.com> <1242865694-2100-15-git-send-email-ebiederm@xmission.com> <1242865694-2100-16-git-send-email-ebiederm@xmission.com> <1242865694-2100-17-git-send-email-ebiederm@xmission.com> <124 2865694-2100-18-git-send-email-ebiederm@xmission.com> <1242865694-2100-19-git-send-email-ebiederm@xmission.com> <1242865694-2100-20-git-send-email-ebiederm@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Andrew Morton , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Cornelia Huck , linux-fsdevel@vger.kernel.org, "Eric W. Biederman" To: "Eric W. Biederman" Return-path: Received: from hera.kernel.org ([140.211.167.34]:43808 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751635AbZEUJoS (ORCPT ); Thu, 21 May 2009 05:44:18 -0400 In-Reply-To: <1242865694-2100-20-git-send-email-ebiederm@xmission.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Eric W. Biederman wrote: > From: Eric W. Biederman > > Use a single error exit path instead of doing whatever > is the required cleanup at each point we find the error. > Ultimately this should make the code more maintainable. > > Signed-off-by: Eric W. Biederman For 0018-0020, Acked-by: Tejun Heo Thanks. -- tejun