From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: Re: [PATCH] writeback: skip new or to-be-freed inodes Date: Mon, 08 Jun 2009 10:03:10 +0300 Message-ID: <4A2CB7AE.6080909@gmail.com> References: <20090324155655.2684.61FB500B@jp.fujitsu.com> <20090324074457.GA7745@localhost> <20090324120502.GC23439@duck.suse.cz> <20090324124001.GA25326@localhost> <4A244A5B.7070605@sandeen.net> <20090602085523.GC7161@localhost> <20090602113736.GB15010@duck.suse.cz> <20090603141021.GB5738@localhost> <20090603141636.GC5650@duck.suse.cz> <20090603144711.GC5738@localhost> <20090606030725.GA12852@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Jan Kara , Eric Sandeen , Andrew Morton , LKML , Masayoshi MIZUMA , "linux-fsdevel@vger.kernel.org" , "viro@zeniv.linux.org.uk" , Nick Piggin , Jeff Layton To: Wu Fengguang Return-path: Received: from smtp.nokia.com ([192.100.122.233]:34938 "EHLO mgw-mx06.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751203AbZFHHED (ORCPT ); Mon, 8 Jun 2009 03:04:03 -0400 In-Reply-To: <20090606030725.GA12852@localhost> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Wu Fengguang wrote: > The above race and warning didn't turn up because writeback_inodes() = holds > the s_umount lock, so generic_forget_inode() finds MS_ACTIVE and retu= rns > early. But we are not sure the UBIFS calls and future callers will gu= arantee > that. So skip I_WILL_FREE inodes for the sake of safety. The inode states are a bit vague for me, but vs. UBIFS - feel free to ask questions. --=20 Best Regards, Artem Bityutskiy (=D0=90=D1=80=D1=82=D1=91=D0=BC =D0=91=D0=B8=D1=82=D1=8E= =D1=86=D0=BA=D0=B8=D0=B9) -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html