From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB499C43331 for ; Tue, 26 Jan 2021 22:38:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D456E2054F for ; Tue, 26 Jan 2021 22:38:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729310AbhAZWgz (ORCPT ); Tue, 26 Jan 2021 17:36:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405456AbhAZUNo (ORCPT ); Tue, 26 Jan 2021 15:13:44 -0500 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2986DC06174A for ; Tue, 26 Jan 2021 12:13:04 -0800 (PST) Received: by mail-pf1-x432.google.com with SMTP id e19so249510pfh.6 for ; Tue, 26 Jan 2021 12:13:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=MZYb3kMF2SoGhQLq5uahaotIljLrCGTAaVi1yzZyu+E=; b=rQtBBq+7DEn/8UuWrdJpmlK6c2JgXMWkSZxkTYfBFywMyAgDmZ3D6kVk1XD7N4TpHG PvdaUbNm1FtCjSsxSNKYb21sZWE+FesWDmaqZJe1fIRIN+d01oQOLKWNmEyBCUWpaCnA tyRSF3dTrqreqh7gLq8WNVhIakPsxJvlRMGDbiZtfBMgQlpRubYNmTs8aqj5jPNuw3MZ Qj+oYMuu64b3BBGRK2XStdfjft74djPS0nsShYhxMadKUIDsyoYSXbU0KgSCFJ86cr48 BFU4RksGcs+cVjZ/WsOGHyS5w5Ho7RdcZn2+1Xj63/rQ81KjK+iAQW+PBT70u49bbumo if8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=MZYb3kMF2SoGhQLq5uahaotIljLrCGTAaVi1yzZyu+E=; b=mjygZB6mTZhsWbQj6tU8ea5NXOicVwr0DVGKqSP/iPnQE6MjV6EN+zBOs+I3zGeUso 0HCL9uEdCErEb8KxyCf0eF2qJBjdmk76mFL5NFV47mNv3fti1CuaVoFT9vh8gUi654HE bLGBS+bNjyde9v60iXhWP4u37S3Geo1vAyd1KQ/IwAKxOY6sGwArVy2L/XXhZrMp1XQI eLYea5h4ObjMsNnhtoEMwJ5fmq5bvvAxICWUmq+8QM8Osp+MlPZOJfukjh7155BIqlr6 bIkgkumlotvn89GzmYOg5SEJpEuAtDCoUedGO9D2MaoXF0vfB7YKb/TDNsKMN10L3qxm 3whA== X-Gm-Message-State: AOAM531RebQfhEGB7TQmYDnOzjl+icmeESYuyiknhTqByHbOyDiAPL4U vqaL++Sf/KwhsZVrucIm6W6Atw== X-Google-Smtp-Source: ABdhPJwZygl3THYUBXlV0yKqnpk9E6JCOBrWWpJo/lOob6A1GtjpuoLMvN5gWCLSRVFfbY7V4Hp60A== X-Received: by 2002:aa7:8f13:0:b029:1bd:f965:66d8 with SMTP id x19-20020aa78f130000b02901bdf96566d8mr6613362pfr.80.1611691983496; Tue, 26 Jan 2021 12:13:03 -0800 (PST) Received: from [2620:15c:17:3:4a0f:cfff:fe51:6667] ([2620:15c:17:3:4a0f:cfff:fe51:6667]) by smtp.gmail.com with ESMTPSA id 124sm19455216pfd.59.2021.01.26.12.13.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 12:13:01 -0800 (PST) Date: Tue, 26 Jan 2021 12:13:00 -0800 (PST) From: David Rientjes To: Muchun Song cc: Randy Dunlap , Jonathan Corbet , Mike Kravetz , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , Matthew Wilcox , Oscar Salvador , Michal Hocko , "Song Bao Hua (Barry Song)" , David Hildenbrand , =?UTF-8?Q?HORIGUCHI_NAOYA=28=E5=A0=80=E5=8F=A3_=E7=9B=B4=E4=B9=9F=29?= , Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Subject: Re: [External] Re: [PATCH v13 02/12] mm: hugetlb: introduce a new config HUGETLB_PAGE_FREE_VMEMMAP In-Reply-To: Message-ID: <4ab7e425-711f-dad9-6a43-e480d5a92b8a@google.com> References: <20210117151053.24600-1-songmuchun@bytedance.com> <20210117151053.24600-3-songmuchun@bytedance.com> <472a58b9-12cb-3c3-d132-13dbae5174f0@google.com> <2d9bfd8d-a77f-6470-807c-1a71ffeac3ff@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, 26 Jan 2021, Muchun Song wrote: > > I'm not sure that Kconfig is the right place to document functional > > behavior of the kernel, especially for non-configurable options. Seems > > like this is already served by existing comments added by this patch > > series in the files where the description is helpful. > > OK. So do you mean just remove the help text here? > Yeah, I'd suggest removing the help text from a non-configurable Kconfig option and double checking that its substance is available elsewhere (like the giant comment in mm/hugetlb_vmemmap.c).