linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Jerome Glisse <jglisse@redhat.com>, Dave Chinner <david@fromorbit.com>
Cc: lsf-pc@lists.linux-foundation.org, linux-mm@kvack.org,
	linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	"Williams, Dan J" <dan.j.williams@intel.com>
Subject: Re: [LSF/MM TOPIC] Un-addressable device memory and block/fs implications
Date: Tue, 13 Dec 2016 14:08:22 -0800	[thread overview]
Message-ID: <4accd272-7214-c702-aed3-fb131f178162@intel.com> (raw)
In-Reply-To: <20161213212433.GF2305@redhat.com>

On 12/13/2016 01:24 PM, Jerome Glisse wrote:
> 
>>> > > From kernel point of view such memory is almost like any other, it
>>> > > has a struct page and most of the mm code is non the wiser, nor need
>>> > > to be about it. CPU access trigger a migration back to regular CPU
>>> > > accessible page.
>> > 
>> > That sounds ... complex. Page migration on page cache access inside
>> > the filesytem IO path locking during read()/write() sounds like
>> > a great way to cause deadlocks....
> There are few restriction on device page, no one can do GUP on them and
> thus no one can pin them. Hence they can always be migrated back. Yes
> each fs need modification, most of it (if not all) is isolated in common
> filemap helpers.

Huh, that's pretty different from the other ZONE_DEVICE uses.  For
those, you *can* do get_user_pages().

I'd be really interested to see the feature set that these pages have
and how it differs from regular memory and the ZONE_DEVICE memory that
have have in-kernel today.

BTW, how is this restriction implemented?  I would have expected to see
follow_page_pte() or vm_normal_page() getting modified.  I don't see a
single reference to get_user_pages or "GUP" in any of the latest HMM
patch set or the changelogs.

As best I can tell, the slow GUP path will get stuck in a loop inside
follow_page_pte(), while the fast GUP path will allow you to acquire a
reference to the page.  But, maybe I'm reading the code wrong.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-12-13 22:08 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-13 18:15 [LSF/MM TOPIC] Un-addressable device memory and block/fs implications Jerome Glisse
2016-12-13 18:20 ` James Bottomley
2016-12-13 18:55   ` Jerome Glisse
2016-12-13 20:01     ` James Bottomley
2016-12-13 20:22       ` Jerome Glisse
2016-12-13 20:27       ` Dave Hansen
2016-12-13 20:15 ` Dave Chinner
2016-12-13 20:31   ` Jerome Glisse
2016-12-13 21:10     ` Dave Chinner
2016-12-13 21:24       ` Jerome Glisse
2016-12-13 22:08         ` Dave Hansen [this message]
2016-12-13 23:02           ` Jerome Glisse
2016-12-13 22:13         ` Dave Chinner
2016-12-13 22:55           ` Jerome Glisse
2016-12-14  0:14             ` Dave Chinner
2016-12-14  1:07               ` Jerome Glisse
2016-12-14  4:23                 ` Dave Chinner
2016-12-14 16:35                   ` Jerome Glisse
2016-12-14 11:13         ` [Lsf-pc] " Jan Kara
2016-12-14 17:15           ` Jerome Glisse
2016-12-15 16:19             ` Jan Kara
2016-12-15 19:14               ` Jerome Glisse
2016-12-16  8:14                 ` Jan Kara
2016-12-16  3:10               ` Aneesh Kumar K.V
2016-12-19  8:46                 ` Jan Kara
2016-12-19 17:00           ` Aneesh Kumar K.V
2016-12-14  3:55 ` Balbir Singh
2016-12-16  3:14 ` [LSF/MM ATTEND] " Aneesh Kumar K.V
2017-01-16 12:04   ` Anshuman Khandual
2017-01-16 23:15     ` John Hubbard
2017-01-18 11:00   ` [Lsf-pc] " Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4accd272-7214-c702-aed3-fb131f178162@intel.com \
    --to=dave.hansen@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=david@fromorbit.com \
    --cc=jglisse@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lsf-pc@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).