From: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, david@fromorbit.com,
hch@infradead.org, willy@infradead.org
Subject: Re: [PATCH 10/10] mm/migrate.c: call detach_page_private to cleanup code
Date: Tue, 19 May 2020 22:44:42 +0200 [thread overview]
Message-ID: <4b367950-bc52-af31-818e-2b668bf08409@cloud.ionos.com> (raw)
In-Reply-To: <aade5d75-c9e9-4021-6eb7-174a921a7958@cloud.ionos.com>
Hi Andrew,
On 5/19/20 9:35 AM, Guoqing Jiang wrote:
> On 5/19/20 7:12 AM, Andrew Morton wrote:
>> On Sun, 17 May 2020 23:47:18 +0200 Guoqing Jiang
>> <guoqing.jiang@cloud.ionos.com> wrote:
>>
>>> We can cleanup code a little by call detach_page_private here.
>>>
>>> ...
>>>
>>> --- a/mm/migrate.c
>>> +++ b/mm/migrate.c
>>> @@ -804,10 +804,7 @@ static int __buffer_migrate_page(struct
>>> address_space *mapping,
>>> if (rc != MIGRATEPAGE_SUCCESS)
>>> goto unlock_buffers;
>>> - ClearPagePrivate(page);
>>> - set_page_private(newpage, page_private(page));
>>> - set_page_private(page, 0);
>>> - put_page(page);
>>> + set_page_private(newpage, detach_page_private(page));
>>> get_page(newpage);
>>> bh = head;
>> mm/migrate.c: In function '__buffer_migrate_page':
>> ./include/linux/mm_types.h:243:52: warning: assignment makes integer
>> from pointer without a cast [-Wint-conversion]
>> #define set_page_private(page, v) ((page)->private = (v))
>> ^
>> mm/migrate.c:800:2: note: in expansion of macro 'set_page_private'
>> set_page_private(newpage, detach_page_private(page));
>> ^~~~~~~~~~~~~~~~
>>
>> The fact that set_page_private(detach_page_private()) generates a type
>> mismatch warning seems deeply wrong, surely.
>>
>> Please let's get the types sorted out - either unsigned long or void *,
>> not half-one and half-the other. Whatever needs the least typecasting
>> at callsites, I suggest.
>
> Sorry about that, I should notice the warning before. I will double
> check if other
> places need the typecast or not, then send a new version.
Only this patch missed the typecast. I guess I just need to send an
updated patch
to replace this one (I am fine to send a new patch set if you want),
sorry again for
the trouble.
>
>> And can we please implement set_page_private() and page_private() with
>> inlined C code? There is no need for these to be macros.
>
> Just did a quick change.
>
> -#define page_private(page) ((page)->private)
> -#define set_page_private(page, v) ((page)->private = (v))
> +static inline unsigned long page_private(struct page *page)
> +{
> + return page->private;
> +}
> +
> +static inline void set_page_private(struct page *page, unsigned long
> priv_data)
> +{
> + page->private = priv_data;
> +}
>
> Then I get error like.
>
> fs/erofs/zdata.h: In function ‘z_erofs_onlinepage_index’:
> fs/erofs/zdata.h:126:8: error: lvalue required as unary ‘&’ operand
> u.v = &page_private(page);
> ^
>
> I guess it is better to keep page_private as macro, please correct me
> in case I
> missed something.
Lost of problems need to be fixed if change page_private to inline
function, so I
think it is better to keep it and only convert set_page_private.
mm/compaction.c: In function ‘isolate_migratepages_block’:
./include/linux/compiler.h:287:20: error: lvalue required as unary ‘&’
operand
__read_once_size(&(x), __u.__c, sizeof(x)); \
^
./include/linux/compiler.h:293:22: note: in expansion of macro ‘__READ_ONCE’
#define READ_ONCE(x) __READ_ONCE(x, 1)
^~~~~~~~~~~
mm/internal.h:293:34: note: in expansion of macro ‘READ_ONCE’
#define page_order_unsafe(page) READ_ONCE(page_private(page))
Thanks,
Guoqing
next prev parent reply other threads:[~2020-05-19 20:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 21:47 [PATCH 00/10] Introduce attach/detach_page_private to cleanup code Guoqing Jiang
2020-05-17 21:47 ` [PATCH 01/10] include/linux/pagemap.h: introduce attach/detach_page_private Guoqing Jiang
2020-05-17 21:47 ` [PATCH 02/10] md: remove __clear_page_buffers and use attach/detach_page_private Guoqing Jiang
2020-05-17 21:47 ` [PATCH 03/10] btrfs: " Guoqing Jiang
2020-05-17 21:47 ` [PATCH 04/10] fs/buffer.c: " Guoqing Jiang
2020-05-17 21:47 ` [PATCH 05/10] f2fs: " Guoqing Jiang
2020-05-17 21:47 ` [PATCH 06/10] iomap: " Guoqing Jiang
2020-05-17 21:47 ` [PATCH 07/10] ntfs: replace attach_page_buffers with attach_page_private Guoqing Jiang
2020-05-17 21:47 ` [PATCH 08/10] orangefs: use attach/detach_page_private Guoqing Jiang
2020-05-26 21:54 ` Mike Marshall
2020-05-28 8:39 ` Guoqing Jiang
2020-05-17 21:47 ` [PATCH 09/10] buffer_head.h: remove attach_page_buffers Guoqing Jiang
2020-05-17 21:47 ` [PATCH 10/10] mm/migrate.c: call detach_page_private to cleanup code Guoqing Jiang
2020-05-19 5:12 ` Andrew Morton
2020-05-19 7:35 ` Guoqing Jiang
2020-05-19 10:06 ` Gao Xiang
2020-05-19 11:02 ` Guoqing Jiang
2020-05-19 11:31 ` Gao Xiang
2020-05-19 15:16 ` Matthew Wilcox
2020-05-19 15:27 ` Gao Xiang
2020-05-19 20:44 ` Guoqing Jiang [this message]
2020-05-21 22:52 ` Dave Chinner
2020-05-22 7:18 ` Guoqing Jiang
2020-05-22 23:53 ` Andrew Morton
2020-05-24 19:02 ` Guoqing Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b367950-bc52-af31-818e-2b668bf08409@cloud.ionos.com \
--to=guoqing.jiang@cloud.ionos.com \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).