From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f195.google.com ([209.85.223.195]:34543 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751539AbeEVSa6 (ORCPT ); Tue, 22 May 2018 14:30:58 -0400 Received: by mail-io0-f195.google.com with SMTP id p124-v6so19661767iod.1 for ; Tue, 22 May 2018 11:30:58 -0700 (PDT) Subject: Re: [PATCH v7 0/5] AIO add per-command iopriority To: Al Viro Cc: adam.manzanares@wdc.com, linux-fsdevel@vger.kernel.org, bcrl@kvack.org, mingo@kernel.org, tglx@linutronix.de, kstewart@linuxfoundation.org, peterz@infradead.org, pombredanne@nexb.com, gregkh@linuxfoundation.org, bigeasy@linutronix.de, rgoldwyn@suse.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-aio@kvack.org, linux-api@vger.kernel.org, hch@infradread.org, jmoyer@redhat.com References: <20180522175221.2391-1-adam.manzanares@wdc.com> <20180522183019.GD30522@ZenIV.linux.org.uk> From: Jens Axboe Message-ID: <4b8732e8-1c51-3181-56a1-d03f7b229f63@kernel.dk> Date: Tue, 22 May 2018 12:30:53 -0600 MIME-Version: 1.0 In-Reply-To: <20180522183019.GD30522@ZenIV.linux.org.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 5/22/18 12:30 PM, Al Viro wrote: > On Tue, May 22, 2018 at 11:55:04AM -0600, Jens Axboe wrote: >> On 5/22/18 11:52 AM, adam.manzanares@wdc.com wrote: >>> From: Adam Manzanares >>> >>> This is the per-I/O equivalent of the ioprio_set system call. >>> See the following link for performance implications on a SATA HDD: >>> https://lkml.org/lkml/2016/12/6/495 >>> >>> First patch factors ioprio_check_cap function out of ioprio_set system call to >>> also be used by the aio ioprio interface. >>> >>> Second patch converts kiocb ki_hint field to a u16 to avoid kiocb bloat. >>> >>> Third patch passes ioprio hint from aio iocb to kiocb and initializes kiocb >>> ioprio value appropriately when it is not explicitly set. >>> >>> Fourth patch enables the feature for blkdev. >>> >>> Fifth patch enables the feature for iomap direct IO >> >> LGTM, you can add: >> >> Reviewed-by: Jens Axboe >> >> Al, are you picking this series up, or should I? > > Probably better if I do, once I finish reviewing Christoph's patchset - > we already have a bunch of stuff around fs/aio.c in this cycle... Alright, sounds good, thanks Al. -- Jens Axboe