From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11ACEC31E48 for ; Wed, 12 Jun 2019 13:39:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E3B6D208CA for ; Wed, 12 Jun 2019 13:39:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408268AbfFLNjG convert rfc822-to-8bit (ORCPT ); Wed, 12 Jun 2019 09:39:06 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([207.82.80.151]:21627 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732408AbfFLNjG (ORCPT ); Wed, 12 Jun 2019 09:39:06 -0400 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-66-VETJ8E46Mh-MLo7lg8Dqqg-1; Wed, 12 Jun 2019 14:39:02 +0100 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Wed, 12 Jun 2019 14:39:00 +0100 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Wed, 12 Jun 2019 14:39:00 +0100 From: David Laight To: 'Oleg Nesterov' CC: "'Eric W. Biederman'" , 'Andrew Morton' , 'Deepa Dinamani' , "'linux-kernel@vger.kernel.org'" , "'arnd@arndb.de'" , "'dbueso@suse.de'" , "'axboe@kernel.dk'" , "'dave@stgolabs.net'" , "'e@80x24.org'" , "'jbaron@akamai.com'" , "'linux-fsdevel@vger.kernel.org'" , "'linux-aio@kvack.org'" , "'omar.kilani@gmail.com'" , "'tglx@linutronix.de'" , 'Al Viro' , 'Linus Torvalds' , "'linux-arch@vger.kernel.org'" Subject: RE: [RFC PATCH 1/5] signal: Teach sigsuspend to use set_user_sigmask Thread-Topic: [RFC PATCH 1/5] signal: Teach sigsuspend to use set_user_sigmask Thread-Index: AQHVH9JWknGdQ9+D0UeylJNmvFzQKKaWJ31QgAAjZdCAAbHqlYAAAXJw///4tQCAABGpsA== Date: Wed, 12 Jun 2019 13:39:00 +0000 Message-ID: <4f5f36915e484b5a9d12e840c79f54cb@AcuMS.aculab.com> References: <20190604134117.GA29963@redhat.com> <20190606140814.GA13440@redhat.com> <87k1dxaxcl.fsf_-_@xmission.com> <87ef45axa4.fsf_-_@xmission.com> <20190610162244.GB8127@redhat.com> <87lfy96sta.fsf@xmission.com> <9199239a450d4ea397783ccf98742220@AcuMS.aculab.com> <95decc6904754004af8a5546aca0468a@AcuMS.aculab.com> <87pnnj2ca0.fsf@xmission.com> <20190612133519.GA3276@redhat.com> In-Reply-To: <20190612133519.GA3276@redhat.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-MC-Unique: VETJ8E46Mh-MLo7lg8Dqqg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org From: Oleg Nesterov > Sent: 12 June 2019 14:35 > On 06/12, David Laight wrote: > > > > > > If I add a signal handler for SIGINT it is called when pselect() > > > > returns regardless of the return value. > > > > > > That is odd. Is this with Oleg's fix applied? > > > > No it is a 5.1.0-rc5 kernel with no related local patches. > > So it is the 'historic' behaviour of pselect(). > > No, this is not historic behaviour, > > > But not the original one! Under 2.6.22-5-31 the signal handler isn't caller > > when pselect() returns 1. > > This is historic behaviour. > > And it was broken by 854a6ed56839a4 ("signal: Add restore_user_sigmask()"). > > And this is what we already discussed many, many times in this thread ;) My brain hurts :-) David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)