From: David Howells <dhowells@redhat.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: dhowells@redhat.com, jlayton@kernel.org,
linux-afs@lists.infradead.org, ceph-devel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] afs: Fix afs_write_end() to handle short writes
Date: Mon, 14 Jun 2021 22:11:26 +0100 [thread overview]
Message-ID: <501527.1623705086@warthog.procyon.org.uk> (raw)
In-Reply-To: <YMd5BqIKucO6rW4R@casper.infradead.org>
Matthew Wilcox <willy@infradead.org> wrote:
> > means you can't get there unless PageUptodate() is true by that point.
>
> Isn't the point of an assertion to check that this is true?
The assertion was meant to check that that it was true given that the page was
set uptodate somewhere else before this function was even called. With this
patch, however, it's now set in this function if it wasn't already right at
the top - so the assertion should now be redundant. I can put it back if you
really insist.
David
next prev parent reply other threads:[~2021-06-14 21:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 13:20 [PATCH 1/3] afs: Handle len being extending over page end in write_begin/write_end David Howells
2021-06-14 13:20 ` [PATCH 2/3] afs: Fix afs_write_end() to handle short writes David Howells
2021-06-14 13:28 ` Matthew Wilcox
2021-06-14 13:37 ` David Howells
2021-06-14 13:46 ` Matthew Wilcox
2021-06-18 3:40 ` Al Viro
2021-06-14 14:04 ` David Howells
2021-06-14 14:37 ` Matthew Wilcox
2021-06-14 15:38 ` David Howells
2021-06-14 15:43 ` Matthew Wilcox
2021-06-14 21:11 ` David Howells [this message]
2021-06-14 13:20 ` [PATCH 3/3] netfs: fix test for whether we can skip read when writing beyond EOF David Howells
2021-06-15 17:01 ` Jeff Layton
2021-06-14 13:33 ` David Howells
2021-06-17 7:43 ` [PATCH 1/3] afs: Handle len being extending over page end in write_begin/write_end kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501527.1623705086@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).