From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4153C432C3 for ; Fri, 15 Nov 2019 10:02:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 962E020730 for ; Fri, 15 Nov 2019 10:02:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727323AbfKOKCO (ORCPT ); Fri, 15 Nov 2019 05:02:14 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:6235 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727208AbfKOKCO (ORCPT ); Fri, 15 Nov 2019 05:02:14 -0500 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 9B515235D03C22C3EF3F; Fri, 15 Nov 2019 18:02:12 +0800 (CST) Received: from [127.0.0.1] (10.173.220.96) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.439.0; Fri, 15 Nov 2019 18:02:06 +0800 Subject: Re: [PATCH 1/3] dcache: add a new enum type for 'dentry_d_lock_class' To: Greg KH CC: , , , , , , , , , , , , , References: <1573788472-87426-1-git-send-email-yukuai3@huawei.com> <1573788472-87426-2-git-send-email-yukuai3@huawei.com> <20191115032759.GA795729@kroah.com> From: "yukuai (C)" Message-ID: <50b4c5eb-c0a0-541f-1b3d-376d1751ec78@huawei.com> Date: Fri, 15 Nov 2019 18:02:05 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191115032759.GA795729@kroah.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.220.96] X-CFilter-Loop: Reflected Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 2019/11/15 11:27, Greg KH wrote: > On Fri, Nov 15, 2019 at 11:27:50AM +0800, yu kuai wrote: >> 'dentry_d_lock_class' can be used for spin_lock_nested in case lockdep >> confused about two different dentry take the 'd_lock'. >> >> However, a single 'DENTRY_D_LOCK_NESTED' may not be enough if more than >> two dentry are involed. So, and in 'DENTRY_D_LOCK_NESTED_2' >> >> Signed-off-by: yu kuai >> --- >> include/linux/dcache.h | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/include/linux/dcache.h b/include/linux/dcache.h >> index 10090f1..8eb84ef 100644 >> --- a/include/linux/dcache.h >> +++ b/include/linux/dcache.h >> @@ -129,7 +129,8 @@ struct dentry { >> enum dentry_d_lock_class >> { >> DENTRY_D_LOCK_NORMAL, /* implicitly used by plain spin_lock() APIs. */ >> - DENTRY_D_LOCK_NESTED >> + DENTRY_D_LOCK_NESTED, >> + DENTRY_D_LOCK_NESTED_2 > > You should document this, as "_2" does not make much sense to anyone > only looking at the code :( > > Or rename it better. > Thank you for your advise, I'll try to rename it better with comments. Yu Kuai > thanks, > > greg k-h > > . >