From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5642EC43215 for ; Fri, 29 Nov 2019 16:36:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 34A5B21736 for ; Fri, 29 Nov 2019 16:36:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727022AbfK2QgB convert rfc822-to-8bit (ORCPT ); Fri, 29 Nov 2019 11:36:01 -0500 Received: from lithops.sigma-star.at ([195.201.40.130]:44102 "EHLO lithops.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726608AbfK2QgA (ORCPT ); Fri, 29 Nov 2019 11:36:00 -0500 Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id A3CB6607BDB2; Fri, 29 Nov 2019 17:35:56 +0100 (CET) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id kOcQPONK-3hk; Fri, 29 Nov 2019 17:35:54 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id D5E1B6083139; Fri, 29 Nov 2019 17:35:53 +0100 (CET) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Au7ORLC9cK4z; Fri, 29 Nov 2019 17:35:53 +0100 (CET) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id 8329F607BDB2; Fri, 29 Nov 2019 17:35:53 +0100 (CET) Date: Fri, 29 Nov 2019 17:35:53 +0100 (CET) From: Richard Weinberger To: Andreas Gruenbacher Cc: Christoph Hellwig , Darrick , torvalds , linux-kernel , Al Viro , Jeff Layton , Sage Weil , Ilya Dryomov , tytso , Andreas Dilger , Jaegeuk Kim , Chao Yu , linux-xfs@vger.kernel.org, linux-fsdevel , Artem Bityutskiy , Adrian Hunter , ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd , Chris Mason , Josef Bacik , David Sterba , linux-btrfs Message-ID: <51833696.101442.1575045353332.JavaMail.zimbra@nod.at> In-Reply-To: <20191129142045.7215-1-agruenba@redhat.com> References: <20191129142045.7215-1-agruenba@redhat.com> Subject: Re: [PATCH v2] fs: Fix page_mkwrite off-by-one errors MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [195.201.40.130] X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF68 (Linux)/8.8.12_GA_3809) Thread-Topic: Fix page_mkwrite off-by-one errors Thread-Index: OwUcLuBZ37Awg+4d3rXFBEMLhx0YIg== Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org ----- Ursprüngliche Mail ----- > Von: "Andreas Gruenbacher" > An: "Christoph Hellwig" , "Darrick" > CC: "Andreas Gruenbacher" , "torvalds" , "linux-kernel" > , "Al Viro" , "Jeff Layton" , "Sage Weil" > , "Ilya Dryomov" , "tytso" , "Andreas Dilger" > , "Jaegeuk Kim" , "Chao Yu" , linux-xfs@vger.kernel.org, > "linux-fsdevel" , "richard" , "Artem Bityutskiy" , > "Adrian Hunter" , ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org, > linux-f2fs-devel@lists.sourceforge.net, "linux-mtd" , "Chris Mason" , "Josef > Bacik" , "David Sterba" , "linux-btrfs" > Gesendet: Freitag, 29. November 2019 15:20:45 > Betreff: [PATCH v2] fs: Fix page_mkwrite off-by-one errors > The check in block_page_mkwrite meant to determine whether an offset is > within the inode size is off by one. This bug has spread to > iomap_page_mkwrite and to several filesystems (ubifs, ext4, f2fs, ceph). > To fix that, introduce a new page_mkwrite_check_truncate helper that > checks for truncate and computes the bytes in the page up to EOF, and > use that helper in the above mentioned filesystems and in btrfs. > > Signed-off-by: Andreas Gruenbacher Thank you for fixing UBIFS! Acked-by: Richard Weinberger Thanks, //richard