From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Revert "aio: block exit_aio() until all context requests are completed"
Date: Fri, 15 May 2015 09:41:47 +0200
Message-ID: <5555A33B.20006@de.ibm.com>
References: <1431675417-30464-1-git-send-email-borntraeger@de.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
Cc: linux-aio@kvack.org, linux-fsdevel@vger.kernel.org
To: Gu Zheng <guz.fnst@cn.fujitsu.com>, Benjamin LaHaise <bcrl@kvack.org>
Return-path: <owner-linux-aio@kvack.org>
In-Reply-To: <1431675417-30464-1-git-send-email-borntraeger@de.ibm.com>
Sender: owner-linux-aio@kvack.org
List-Id: linux-fsdevel.vger.kernel.org

I see a significant latency (can be minutes with 2000 disks and HZ=100)
when exiting a QEMU process that has lots of disk devices via aio. The
process sits idle doing nothing as zombie in exit_aio waiting for the
completion.

Turns out that 
commit 6098b45b32 ("aio: block exit_aio() until all context requests are
completed") caused the delay.

Patch description was:

It seems that exit_aio() also needs to wait for all iocbs to complete (like
io_destroy), but we missed the wait step in current implemention, so fix
it in the same way as we did in io_destroy.

Now: io_destroy requires to block until everything is cleaned up from its
interface description in the manpage:
DESCRIPTION
The  io_destroy()  system call will attempt to cancel all outstanding
asynchronous I/O operations against ctx_id, will block on the completion
of all operations that could not be canceled, and will destroy the ctx_id.

Does process exit require the same full blocking? We might be able to
cleanup the process and let the aio data structures be freed lazily.
Opinions or better ideas?

Christian

diff --git a/fs/aio.c b/fs/aio.c
index a793f70..1e6bcdb 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -820,8 +820,6 @@ void exit_aio(struct mm_struct *mm)

 	for (i = 0; i < table->nr; ++i) {
 		struct kioctx *ctx = table->table[i];
-		struct completion requests_done =
-			COMPLETION_INITIALIZER_ONSTACK(requests_done);

 		if (!ctx)
 			continue;
@@ -833,10 +831,7 @@ void exit_aio(struct mm_struct *mm)
 		 * that it needs to unmap the area, just set it to 0.
 		 */
 		ctx->mmap_size = 0;
-		kill_ioctx(mm, ctx, &requests_done);
-
-		/* Wait until all IO for the context are done. */
-		wait_for_completion(&requests_done);
+		kill_ioctx(mm, ctx, NULL);
 	}

 	RCU_INIT_POINTER(mm->ioctx_table, NULL);


--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org.  For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>