From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:37023 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753713AbcHANZR (ORCPT ); Mon, 1 Aug 2016 09:25:17 -0400 Message-ID: <579F4D92.6020701@osg.samsung.com> Date: Mon, 01 Aug 2016 14:24:34 +0100 From: Luis de Bethencourt MIME-Version: 1.0 To: Salah Triki , akpm@linux-foundation.org, viro@zeniv.linux.org.uk CC: mhocko@suse.com, vdavydov@virtuozzo.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] fs: befs: remove in vain variable assignment References: In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 31/07/16 21:34, Salah Triki wrote: > There is no need to set *value, it will be overwritten later. > > Signed-off-by: Salah Triki > --- > fs/befs/btree.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/befs/btree.c b/fs/befs/btree.c > index a0e8cfa..f33fc6c 100644 > --- a/fs/befs/btree.c > +++ b/fs/befs/btree.c > @@ -348,8 +348,6 @@ befs_find_key(struct super_block *sb, struct befs_btree_node *node, > > befs_debug(sb, "---> %s %s", __func__, findkey); > > - *value = 0; > - > findkey_len = strlen(findkey); > > /* if node can not contain key, just skeep this node */ > Hi Salah, The key here is that befs_btree_find(), the only consumer of befs_find_key(), doesn't use the value if the return is BEFS_BT_NOT_FOUND. Tested the patch anyway to be sure. Acked-by: Luis de Bethencourt Pushed to the befs-next branch: https://github.com/luisbg/linux-befs/tree/befs-next Thanks! Luis