From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:37104 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751078AbcHANpv (ORCPT ); Mon, 1 Aug 2016 09:45:51 -0400 Message-ID: <579F5232.401@osg.samsung.com> Date: Mon, 01 Aug 2016 14:44:18 +0100 From: Luis de Bethencourt MIME-Version: 1.0 To: Salah Triki , akpm@linux-foundation.org, viro@zeniv.linux.org.uk CC: mhocko@suse.com, vdavydov@virtuozzo.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] fs: befs: remove useless initialization to zero References: <1fee3d0091bc23fa0c4fed25382f37270d290d44.1469997250.git.salah.triki@gmail.com> In-Reply-To: <1fee3d0091bc23fa0c4fed25382f37270d290d44.1469997250.git.salah.triki@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 31/07/16 21:34, Salah Triki wrote: > node_off is unconditionally set to bt_super.root_node_ptr, so no need to > init it to zero. > > Signed-off-by: Salah Triki > --- > fs/befs/btree.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/befs/btree.c b/fs/befs/btree.c > index f33fc6c..3cb97e8 100644 > --- a/fs/befs/btree.c > +++ b/fs/befs/btree.c > @@ -420,7 +420,7 @@ befs_btree_read(struct super_block *sb, const befs_data_stream *ds, > { > struct befs_btree_node *this_node; > befs_btree_super bt_super; > - befs_off_t node_off = 0; > + befs_off_t node_off; > int cur_key; > fs64 *valarray; > char *keystart; > Looks good to me. Strange that static analysis didn't pick this one up before. Acked-by: Luis de Bethencourt Pushed to the befs-next branch: https://github.com/luisbg/linux-befs/tree/befs-next Thanks Salah, Luis