From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga06-in.huawei.com ([45.249.212.32]:47519 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725765AbeHBEkt (ORCPT ); Thu, 2 Aug 2018 00:40:49 -0400 Message-ID: <5B6271C6.7030104@huawei.com> Date: Thu, 2 Aug 2018 10:51:50 +0800 From: zhong jiang MIME-Version: 1.0 To: CC: , Subject: Re: [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote References: <1533175474-17785-1-git-send-email-zhongjiang@huawei.com> In-Reply-To: <1533175474-17785-1-git-send-email-zhongjiang@huawei.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: plese ingore it. On 2018/8/2 10:04, zhong jiang wrote: > It is unncessary to use double test for a expression. so just > remove one of them. > > Signed-off-by: zhong jiang > --- > fs/binfmt_elf_fdpic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c > index b53bb37..5162372 100644 > --- a/fs/binfmt_elf_fdpic.c > +++ b/fs/binfmt_elf_fdpic.c > @@ -1288,7 +1288,7 @@ static int writenote(struct memelfnote *men, struct coredump_params *cprm) > > return dump_emit(cprm, &en, sizeof(en)) && > dump_emit(cprm, men->name, en.n_namesz) && dump_align(cprm, 4) && > - dump_emit(cprm, men->data, men->datasz) && dump_align(cprm, 4); > + dump_emit(cprm, men->data, men->datasz); > } > > static inline void fill_elf_fdpic_header(struct elfhdr *elf, int segs)